tanaypratap / teamtanay.jobchallenge.dev

The web repository for all things #teamtanayjobchallenge
https://2020.teamtanay.jobchallenge.dev
131 stars 429 forks source link

[Project][Feedback] Tindev #510

Closed swapnadeepmohapatra closed 4 years ago

swapnadeepmohapatra commented 4 years ago

Hey Guys,

I hope you all are doing fine. I have made this full-stack Social Network App with MERN stack named Tindev. Researching co-workers is something difficult. Tindev offers you the opportunity to simply accelerate the process by finding out which is the best match. With this, you can log in with your GitHub ID and you can swipe through different devs and if two devs like each other then they match and they can chat over this app. Through this, they can get the best co-worker for them and maybe the co-founder of a big firm.

I also have converted this into a PWA so that it can be downloaded and can be used as a mobile app also a Windows app.

Link of the site -> https://tindev.swapnadeep.com/

And thank you in advance for helping us out.

suryanshsugandhi commented 4 years ago

I am not a mentor, but that looks clean and promising. If you're willing to work more on it, github sign in is very easy to implement. Swiped right on a lot of devs. Looking to connect xD

swapnadeepmohapatra commented 4 years ago

I was working on the passport.js to do so but will see if GitHub login will be good to integrate with this.

swapagarwal commented 4 years ago

@swapnadeepmohapatra Nice work! :)

Here's the detailed feedback:

P.S. I liked your proactiveness. You wanted a review so you DMed folks. Simple as that. This is an underrated skill and it'll help you a lot in getting things done. Don't go overboard though (nobody likes spam :P)!

swapnadeepmohapatra commented 4 years ago

Hello @swapagarwal .

Thank you for such a detailed review. I have taken care of many points.

Some other improvements

More Scope of Improvements

Food for Thought / out of scope question

And thank you for helping me a lot in improving my site.

swapnadeepmohapatra commented 4 years ago

Hello @swapagarwal ,

I have updated the website one more time. Here I have made the following changes.

image

Thanks, Swapnadeep

swapagarwal commented 4 years ago

@swapnadeepmohapatra Awesome! 🔥 Can you also attach the GitHub repo? I'll take a final look together. ✌️

swapnadeepmohapatra commented 4 years ago

Thank you @swapagarwal

Here is the GitHub Repo -

Forntend Backend

swapagarwal commented 4 years ago

Hey @swapnadeepmohapatra, I took a look at the updated site and you've incorporated most of the changes pretty fast so kudos for that. 💯

There's some scope of improvement in your coding style, e.g. use more descriptive names than a,b,arr,pc, avoid hardcoding css styles, etc. The good thing is that you'll learn these things with experience. You can get a head-start by reading the book Clean Code. Feel free to ping me on Telegram if you need any help.

Oh, and by the way, I can't believe you're in class 10th. You're doing amazing things! 🙌

swapnadeepmohapatra commented 4 years ago

Thank you @swapagarwal . I am really bad at naming variables. I am trying to get better at this by taking a look at some of the enterprise-level open-source code.