[Project-1 Review] Sorting Visualizer

tanaypratap / teamtanay.jobchallenge.dev

The web repository for all things #teamtanayjobchallenge

https://2020.teamtanay.jobchallenge.dev

131 stars 430 forks source link

[Project-1 Review] Sorting Visualizer #618

Open manmodesanket opened 4 years ago

manmodesanket commented 4 years ago

Hi mentors,

Please review my project.

Build a VanillaJS application which is a sorting visualizer. Implemented bubble sort, insertion sort, merge sort and quick sort.

Github Link - https://github.com/manmodesanket/sorting-visualizer Hosted here - https://sortingvisualizer1.netlify.app/

BaseMax commented 4 years ago

Hello,

Good idea,

My suggestions:

You need to put a stop button there. (Maybe a stop button near play/pause button or another idea)
Also add: <!doctype html>
Unable to change sort method while sorting array...
When user click on a sort method, you can switch method. (stop previous method and create and start new)

Regards, Max Base

manmodesanket commented 4 years ago

Hello Max, I have added stop button but currently it works only on Bubble Sort and Insertion Sort. I am working on how to make it work for for Merge and Quick Sort.