search

tanbro / pyyaml-include

yaml include other yaml
https://pypi.org/project/pyyaml-include/
GNU General Public License v3.0
78 stars 20 forks source link

Python 3.6 unsupported after releasing `1.2.post1` #16

Closed idanh closed 3 years ago

idanh commented 3 years ago

Hi, re.Pattern is Python 3.7+

On your latest release, 1.2.post1, you've included:

...
  File "/usr/local/lib/python3.6/site-packages/yamlinclude/__init__.py", line 7, in <module>
    from .constructor import *
  File "/usr/local/lib/python3.6/site-packages/yamlinclude/constructor.py", line 24, in <module>
    class YamlIncludeConstructor:
  File "/usr/local/lib/python3.6/site-packages/yamlinclude/constructor.py", line 46, in YamlIncludeConstructor
    reader_map: Collection[Tuple[Union[str, re.Pattern], Reader]] = None
AttributeError: module 're' has no attribute 'Pattern'

I guess either by mistake, or you removed support for 3.6 and didn't include that in your release notes anywhere :)

FYI

tanbro commented 3 years ago

Oh! thanks.

i'm fixing it on 1b0a366846066d3f70b1e5033bc3949df0a64f88

tanbro commented 3 years ago

1.2.post2 solved these problems.

thank you @idanh !