bryanwrightscode
commented
3 years ago fantasticon -c fantasticonrc.json
The option '$schema' is not recognised
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! bryanwrightscode-icons@0.0.2 fonts: fantasticon -c fantasticonrc.json
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the bryanwrightscode-icons@0.0.2 fonts script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR! C:\Users\bwright\AppData\Roaming\npm-cache_logs\2021-07-31T01_39_23_000Z-debug.lognpm ERR! code ELIFECYCLELE
npm ERR! errno 1 ll cp -Recurse dist/brya
npm ERR! bryanwrightscode-icons@0.0.2 dev: npm run clean && npm run move && npm run svgo && npm run fonts && powershell cp -Recurse dist/bryanwrightscode-icons.ttf theme/bryanwrightscode-icons.ttf
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the bryanwrightscode-icons@0.0.2 dev script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in: scode\extensions\bryanwr npm ERR! C:\Users\bwright\AppData\Roaming\npm-cache_logs\2021-07-31T01_39_23_029Z-debug.logPS C:\Users\bwright.vscode\extensions\bryanwrightscode.product-icons-0.0.2>
JSON schemas are used by specifying the JSON schema location as a string for the property whose string key is "$schema". I found it helpful to write a schema for the config structure in my fantasticonrc.json file. However when running fantasticon command, when parseConfig encounters the json file that uses the schema, the function includes all keys within the provided json file, even the one named $schema. Since "$schema" is not listed inside CONFIG_VALIDATORS, parseConfig throws an error that the key is not recognized. I suggest updating the parseConfig function to include an edge case where if a provided key is not part of CONFIG_VALIDATORS, only throw an error if it is also not equal to "$schema." Alternatively, include an optional $schema key to CONFIG_VALIDATORS, whose type is a string.