CSS Breakpoint off on published site

tancredi / nodeconf-london-2016

NodeConf London 2016 Website

9 stars 14 forks source link

CSS Breakpoint off on published site #53

Closed TinyExplosions closed 8 years ago

TinyExplosions commented 8 years ago

Based on the tweet at https://twitter.com/McDonnellDean/status/712270469672599557 -the publilshed version of the site has mobile-breakpoint set to 400px. However, in variables.styl is it (correctly) set to 600px, which means the referenced issue no longer happens on an iPhone 6+ sized device.

There's not really anything that needs to be changed, PR wise, I think the site just needs to be rebuilt!

TinyExplosions commented 8 years ago

Actually, it appears that the 400px breakpoint is one defined by griddy, not by the site, so will require a fix it seems

tancredi commented 8 years ago

@TinyExplosions good spot - Will fix later on today - Griddy takes a configuration variable for the mobile breakpoint, so it's just about adding parameters to the grid-system() mixin.

tancredi commented 8 years ago

Fixed in https://github.com/tancredi/nodeconf-london-2016/commit/2003f98f122fd09255c212868fd6692ffaa1fa3d now just needs deploying