search

tandraschko / quarkus-myfaces

26 stars 6 forks source link

Add System tests #12

Open rmpestano opened 5 years ago

rmpestano commented 5 years ago

I think we should have some system tests in order to guarantee we not break the extension on future changes (on the extension itself, myfaces or quakus-core update)

I have done something on quarkus-omnifaces (see here), it uses htmlunit and works quite good.

I also have tried to use selenium with drone/graphene but quarkus team said that users should not rely on quarkus-arquillian extension, see discussion here.

I think we have two options which is:

1 - htmlunit - simpler but less reliable (I think as it emulates a browser) 2 - pure selenium without arquillian - more reliable but a bit more complex and harder to use in CI (travis)

WDYT?

tandraschko commented 5 years ago

+1 for tests in generell Just do it as you like :)

We also need think where we host the project later, see: https://groups.google.com/forum/#!topic/quarkus-dev/yCGtMdnPMV8

rmpestano commented 5 years ago

We also need think where we host the project later

I'm following the discussion on ggroups, don't know if we can host on apache repo, as child/module of myfaces.

tandraschko commented 5 years ago

Not sure... I would like to see it in quarkus - we also don't have e.g. TomEE or WebSphere integration code in the myfaces repo