search

tandraschko / quarkus-myfaces

26 stars 6 forks source link

QuarkusCdiELResolver - Dependent on beans used in EL are currently not supported! #2

Closed rmpestano closed 5 years ago

rmpestano commented 5 years ago

Hi, any special reason for this check? https://github.com/tandraschko/quarkus-myfaces/blob/89f7ce51fb87cf80cbc3c9a28042f840bc4b0dd7/quarkus-myfaces/runtime/src/main/java/io/quarkus/myfaces/runtime/myfaces/QuarkusCdiELResolver.java#L82-L85

I question because I'm getting this FacesException caused by org.apache.myfaces.cdi.JsfArtifactProducer

Screenshot from 2019-05-28 13-53-35

If I comment out this block my sample application works.

rmpestano commented 5 years ago

I think it comes from this el expression on my application:

rendered="#{not empty title and empty requestScope['javax.servlet.error.exception_type'] and empty requestScope['javax.servlet.error.message']}"
tandraschko commented 5 years ago

I Just didn't implement it because its not good performance (each EL will create a new bean instance, requestScope should be prefered) and requires some extra logic. I wonder why requestScope is dependent. Let me check later.

tandraschko commented 5 years ago

fixed it now - you need to rebuild myfaces and the extension. Still it doesn't support @Dependent for EL resolution but i also suggest to don't use it.

rmpestano commented 5 years ago

Working great now! thank you