search

tandusrl / acts_as_bookable

A reservation plugin for Rails applications that allows resources to be bookable.
MIT License
140 stars 103 forks source link

Rails 5 compatibility #15

Closed colemerrick closed 7 years ago

colemerrick commented 8 years ago

Updated gemspec for activerecord 5 compatibility Updated ruby version to latest stable v2.3.1

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.1%) to 98.494% when pulling 3a6a0dd81f6a431a7c9961b5b51cac642b74c4b9 on colemerrick:rails_5_compatibility into 176b6f5129479f44768e9820f23ecac20c249d26 on tandusrl:master.

Chosko commented 8 years ago

Hi, thanks for your contribution. I see that some tests are failing, exactly the ones with activerecord 5. Can you check why?

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.1%) to 98.494% when pulling ac4b49b0d4f76b10e4bcf708be7e11230af3a8c1 on colemerrick:rails_5_compatibility into 176b6f5129479f44768e9820f23ecac20c249d26 on tandusrl:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.1%) to 98.494% when pulling ac4b49b0d4f76b10e4bcf708be7e11230af3a8c1 on colemerrick:rails_5_compatibility into 176b6f5129479f44768e9820f23ecac20c249d26 on tandusrl:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.1%) to 98.494% when pulling ac4b49b0d4f76b10e4bcf708be7e11230af3a8c1 on colemerrick:rails_5_compatibility into 176b6f5129479f44768e9820f23ecac20c249d26 on tandusrl:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.1%) to 98.494% when pulling ac4b49b0d4f76b10e4bcf708be7e11230af3a8c1 on colemerrick:rails_5_compatibility into 176b6f5129479f44768e9820f23ecac20c249d26 on tandusrl:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.1%) to 98.494% when pulling ac4b49b0d4f76b10e4bcf708be7e11230af3a8c1 on colemerrick:rails_5_compatibility into 176b6f5129479f44768e9820f23ecac20c249d26 on tandusrl:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.1%) to 98.494% when pulling ac4b49b0d4f76b10e4bcf708be7e11230af3a8c1 on colemerrick:rails_5_compatibility into 176b6f5129479f44768e9820f23ecac20c249d26 on tandusrl:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.1%) to 98.494% when pulling ac4b49b0d4f76b10e4bcf708be7e11230af3a8c1 on colemerrick:rails_5_compatibility into 176b6f5129479f44768e9820f23ecac20c249d26 on tandusrl:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.1%) to 98.494% when pulling ac4b49b0d4f76b10e4bcf708be7e11230af3a8c1 on colemerrick:rails_5_compatibility into 176b6f5129479f44768e9820f23ecac20c249d26 on tandusrl:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.1%) to 98.494% when pulling ac4b49b0d4f76b10e4bcf708be7e11230af3a8c1 on colemerrick:rails_5_compatibility into 176b6f5129479f44768e9820f23ecac20c249d26 on tandusrl:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.1%) to 98.494% when pulling ac4b49b0d4f76b10e4bcf708be7e11230af3a8c1 on colemerrick:rails_5_compatibility into 176b6f5129479f44768e9820f23ecac20c249d26 on tandusrl:master.

colemerrick commented 8 years ago

Looking into it

Chosko commented 7 years ago

I just fixed this with https://github.com/tandusrl/acts_as_bookable/tree/v0.1.3. A new version v0.1.3 is available at rubygems.org