search

tandusrl / acts_as_bookable

A reservation plugin for Rails applications that allows resources to be bookable.
MIT License
140 stars 104 forks source link

Not compatible with Rails 5 #30

Open AaronRohrbacher opened 6 years ago

AaronRohrbacher commented 6 years ago

And I'd really love it to be!

digifinity commented 6 years ago

Me toooo! thanks :-)

occorom commented 6 years ago

Me too !

etewiah commented 6 years ago

It looks like you can get some mileage out of just editing the gemspec like this guy has done:

https://github.com/vretamal/acts_as_bookable

Would be nice to have it officially supported though

aromaron commented 6 years ago

you can check my fork https://github.com/aromaron/acts_as_bookable

etewiah commented 6 years ago

Thanks @aromaron , is this likely to get merged into the official repo any time soon?

slead commented 5 years ago

you can check my fork https://github.com/aromaron/acts_as_bookable

Hi @aromaron, I used your fork (in a brand new empty Rails 5.2.2 app with no other changes) via gem 'acts_as_bookable', git: 'https://github.com/aromaron/acts_as_bookable' but I'm getting these errors when I try to bundle install or bundle update.

Which version of Ruby and Rails 5 do you recommend in order to use your fork or acts-as-bookable? Thanks

$ bundle update
Fetching https://github.com/aromaron/acts_as_bookable
The dependency tzinfo-data (>= 0) will be unused by any of the platforms Bundler is installing for. Bundler is installing for ruby but the dependency is only for x86-mingw32, x86-mswin32, x64-mingw32, java. To add those platforms to the bundle, run `bundle lock --add-platform x86-mingw32 x86-mswin32 x64-mingw32 java`.
Fetching gem metadata from https://rubygems.org/.........
Fetching gem metadata from https://rubygems.org/.
Resolving dependencies..........
Bundler could not find compatible versions for gem "activemodel":
  In Gemfile:
    rails (>= 5.2.1.1, ~> 5.2.1) was resolved to 5.2.2.rc1, which depends on
      activemodel (= 5.2.2.rc1)

    web-console (>= 3.3.0) was resolved to 3.7.0, which depends on
      activemodel (>= 5.0)

Bundler could not find compatible versions for gem "activerecord":
  In Gemfile:
    acts_as_bookable was resolved to 0.1.4, which depends on
      activerecord (< 5.1, >= 3.2)

    rails (>= 5.2.1.1, ~> 5.2.1) was resolved to 5.2.2.rc1, which depends on
      activerecord (= 5.2.2.rc1)

Bundler could not find compatible versions for gem "activesupport":
  In Gemfile:
    jbuilder (~> 2.5) was resolved to 2.8.0, which depends on
      activesupport (>= 4.2.0)

    rails (>= 5.2.1.1, ~> 5.2.1) was resolved to 5.2.2.rc1, which depends on
      activesupport (= 5.2.2.rc1)

    spring was resolved to 2.0.2, which depends on
      activesupport (>= 4.2)

Bundler could not find compatible versions for gem "railties":
  In Gemfile:
    coffee-rails (~> 4.2) was resolved to 4.2.2, which depends on
      railties (>= 4.0.0)

    rails (>= 5.2.1.1, ~> 5.2.1) was resolved to 5.2.2.rc1, which depends on
      railties (= 5.2.2.rc1)

    sass-rails (~> 5.0) was resolved to 5.0.7, which depends on
      railties (< 6, >= 4.0.0)

    web-console (>= 3.3.0) was resolved to 3.7.0, which depends on
      railties (>= 5.0)
aromaron commented 5 years ago

Hi @slead sorry for the late reply, I'm using:

Ruby 2.3.1 and Rails 5.0

you can check my fork https://github.com/aromaron/acts_as_bookable

Hi @aromaron, I used your fork (in a brand new empty Rails 5.2.2 app with no other changes) via gem 'acts_as_bookable', git: 'https://github.com/aromaron/acts_as_bookable' but I'm getting these errors when I try to bundle install or bundle update.

Which version of Ruby and Rails 5 do you recommend in order to use your fork or acts-as-bookable? Thanks

$ bundle update
Fetching https://github.com/aromaron/acts_as_bookable
The dependency tzinfo-data (>= 0) will be unused by any of the platforms Bundler is installing for. Bundler is installing for ruby but the dependency is only for x86-mingw32, x86-mswin32, x64-mingw32, java. To add those platforms to the bundle, run `bundle lock --add-platform x86-mingw32 x86-mswin32 x64-mingw32 java`.
Fetching gem metadata from https://rubygems.org/.........
Fetching gem metadata from https://rubygems.org/.
Resolving dependencies..........
Bundler could not find compatible versions for gem "activemodel":
  In Gemfile:
    rails (>= 5.2.1.1, ~> 5.2.1) was resolved to 5.2.2.rc1, which depends on
      activemodel (= 5.2.2.rc1)

    web-console (>= 3.3.0) was resolved to 3.7.0, which depends on
      activemodel (>= 5.0)

Bundler could not find compatible versions for gem "activerecord":
  In Gemfile:
    acts_as_bookable was resolved to 0.1.4, which depends on
      activerecord (< 5.1, >= 3.2)

    rails (>= 5.2.1.1, ~> 5.2.1) was resolved to 5.2.2.rc1, which depends on
      activerecord (= 5.2.2.rc1)

Bundler could not find compatible versions for gem "activesupport":
  In Gemfile:
    jbuilder (~> 2.5) was resolved to 2.8.0, which depends on
      activesupport (>= 4.2.0)

    rails (>= 5.2.1.1, ~> 5.2.1) was resolved to 5.2.2.rc1, which depends on
      activesupport (= 5.2.2.rc1)

    spring was resolved to 2.0.2, which depends on
      activesupport (>= 4.2)

Bundler could not find compatible versions for gem "railties":
  In Gemfile:
    coffee-rails (~> 4.2) was resolved to 4.2.2, which depends on
      railties (>= 4.0.0)

    rails (>= 5.2.1.1, ~> 5.2.1) was resolved to 5.2.2.rc1, which depends on
      railties (= 5.2.2.rc1)

    sass-rails (~> 5.0) was resolved to 5.0.7, which depends on
      railties (< 6, >= 4.0.0)

    web-console (>= 3.3.0) was resolved to 3.7.0, which depends on
      railties (>= 5.0)
slead commented 5 years ago

Hi @slead sorry for the late reply, I'm using: Ruby 2.3.1 and Rails 5.0

@aromaron Thanks for the info. I tried:

gem install rails -v 5.0.0
rails _5.0.0_ new my-app

In the gemfile I've got:

ruby '2.3.1'
gem 'acts_as_bookable', git: 'https://github.com/aromaron/acts_as_bookable'

but when I try bundle update I still get:

Bundler could not find compatible versions for gem "activerecord":
  In Gemfile:
    acts_as_bookable was resolved to 0.1.4, which depends on
      activerecord (< 5.1, >= 3.2)

    rails (>= 5.2.1.1, ~> 5.2.1) was resolved to 5.2.1.1, which depends on
      activerecord (= 5.2.1.1)

I don't understand why it's trying to use Rails 5.2.1.1 when I specified Rails 5.0.0? Oh well, I'll figure it out. Let me know if you have any tips!

Thanks again for getting back to me

(PS I tried the above steps but using Rails 4.0.0 and it seems to have worked, which is good enough for me at this stage)

jembuilt commented 5 years ago

@slead not sure if it helps... but I just made a copy for rails 5.2 and ruby 2.6

etewiah commented 5 years ago

@RemyPiper , do you mean you've created a fork that works with rails 5.2? If so it would be nice if you could post the link. Thanks.

azeemh commented 4 years ago

is there a solution that works in 2020?

ruby 2.6.3 rails 5.2.1

edit: I used gem 'acts_as_bookable', git: 'https://github.com/yukas/acts_as_bookable' in my gemfile and did a bundle update.

@yukas TYSM, also let's update your version to 5.2.4.3 it's running with 5.2.4.1 right now but i saw another user put an update for the rails version.