search

taneliang / Cotton

WIP Dependency management GitHub bot for Yarn projects
8 stars 1 forks source link

upgradeRepository may timeout #1

Open taneliang opened 6 years ago

taneliang commented 6 years ago

Repos with many package.jsons (or large dependencies which take a long time to install) may fail to be upgraded as the upgradeRepository lambda may timeout.

One possible solution is to turn upgradeRepository into a step function which will be able to upgrade all files in independent lambdas.

Alternatively, the timeout could be increased. This may be an issue as Serverless complains that lambdas accessible through API Gateway have a maximum timeout of 30s, which sounds like an AWS restriction.

taneliang commented 6 years ago

Step functions seem expensive - only 4000 free transitions, which we'll probably hit very quickly even if we don't have many users.

We could increase the timeout to 5 min if we disable API Gateway access to this lambda, and use a separate HTTP trigger lambda instead. 5 min ought to be enough for anybody.