search

tanelpoder / tpt-oracle

Tanel Poder's Performance & Troubleshooting Tools for Oracle Databases
https://tanelpoder.com
Other
657 stars 312 forks source link

f.sql enhancement #43

Closed patrickjolliffe closed 6 months ago

patrickjolliffe commented 6 months ago

Would you accept a PR to change it to: where upper(view_definition) like upper('%&1%') OR upper(view_name) like upper('%&1%');

(I know i should probably just create the PR then you reject/accept as you see fit, but whatever)

tanelpoder commented 6 months ago

Yeah, it would be nice to make (almost) all of my scripts more consistent regarding commadn line arguments. So with any small enough changes that are clearly inconsistent (because I sometimes create the scripts on the spot while working on some other problem), feel free to submit a PR right away (as it's a simple change and not too much work).

But for any bigger changes, I think opening an issue to discuss it first (like you did right now) is a good way to start.

patrickjolliffe commented 6 months ago

Done!

tanelpoder commented 6 months ago

Merged, thanks!

By the way, should you do any bigger contributions to other scripts in the future (I have ideas :-) then feel free to add your name to the header too (into an updates/changes section)