tanelpoder / tpt-oracle

Tanel Poder's Performance & Troubleshooting Tools for Oracle Databases
https://tanelpoder.com
Other
657 stars 312 forks source link

Cashtop #44

Closed patrickjolliffe closed 5 months ago

patrickjolliffe commented 5 months ago

cashtop CDB specific version of dashtop...

patrickjolliffe commented 5 months ago

LOL I thought I had removed the pull request as I was getting some funky behaviour when actually running it. I think I worked out that this is because of ash entries being duplicated (ie entry in PDB and CDB$ROOT) which I think is expected oracle behavior. Other thing I'd like to do is also fix to allow con_id to be grouping column (currently adding it throws error cos it's referenced in multiple tables)...

tanelpoder commented 5 months ago

Yeah as I'm not too familiar with Github issue/PR management, I saw that this PR request was closed (by you I guess), but I just opened and reviewed + merged it. But I did see some things I wanted to change - I have made a few updates to the script and pushed the changes. Now it should show the CDB$ROOT activity (as NULL) in the PDB_NAME field too. But it might just be easier to use either the CON_ID_TO_CON_NAME() instead of the join to CDB_PDBS or just join to V$CONTAINER (if it would be enough, have to check). Currently I advise people to switch to the PDB of interest anyway, if they're troubleshooting a problem within a specific PDB, so the old ASH/DASH scripts should work.

(Separately, I advise people to enable PDB level AWR in their PDBs too, otherwise some things like creating PDB baselines from CDB$ROOT AWR get complicated)