tanepiper / ngx-tinynodes

Monorepo for components released on NPM @tinynodes
https://tanepiper.github.io/ngx-tinynodes/
Other
38 stars 16 forks source link

[BUG] ngx-editorjs 3.0.2: Angular Material required #10

Closed przemekpobuta closed 5 years ago

przemekpobuta commented 5 years ago

Which Library? ngx-editorjs 3.0.2

Describe the bug Done "Installing and usage" instruction from README and following error appear:

ERROR in node_modules/@tinynodes/ngx-editorjs/lib/containers/editorjs-mat-field/editorjs-mat-field.component.d.ts(4,37): error TS2307: Cannot find module '@angular/material/form-field'.

To Reproduce Steps to reproduce the behavior: Follow README "Installing and usage".

Expected behavior Use ngx-editorjs without Angular Material.

tanepiper commented 5 years ago

Hi @przemekpobuta - you should now be able to import NgxEditorJSComponentModule which is the component minus any Material dependencies. Thanks for catching this, I'm building mostly for material so I missed this.

whyour commented 5 years ago

Hi @tanepiper - still has error. Is it imported like this? NgxEditorJSComponentModule.forRoot({ editorjs: { autofocus: false, holder: 'editor', initialBlock: 'paragraph', data: { time: Date.now(), version: '2.15.0', blocks: [] } } }) image

tanepiper commented 5 years ago

@whyour Thanks for the report, I won't be able to look at it right away I'm afraid but let me find time to test it, hopefully, it's not a regression

tanepiper commented 5 years ago

@whyour I am not able to reproduce this, importing the NgxEditorJSComponentModule. Do you have some code you can share if you're still having an issue?

tanepiper commented 5 years ago

Hi @whyour I haven't had a reply in a week so I am closing this ticket.