search

tanersener / mobile-ffmpeg

FFmpeg for Android, iOS and tvOS. Not maintained anymore. Superseded by FFmpegKit.
https://tanersener.github.io/mobile-ffmpeg
GNU General Public License v3.0
3.86k stars 788 forks source link

does --full when combined with --enable-gpl automatically add the gpl libraries #394

Closed mgood7123 closed 4 years ago

mgood7123 commented 4 years ago

does --full when combined with --enable-gpl automatically add the gpl libraries? for example:

./android.sh \
--enable-gpl \
--full \

or would i need to do

./android.sh \
--speed \
--enable-gpl \
--full \
--enable-rubberband \
--enable-libvidstab \
--enable-x264 \
--enable-x265 \
--enable-xvidcore \
tanersener commented 4 years ago

No, --full does not enable GPL licensed libraries even if you add --enable-gpl option. You need to enable them explicitly.

This behaviour can be changed. I'll think about it.

tanersener commented 4 years ago

Fixed in development.

mgood7123 commented 4 years ago

i just checked out and the changes didnt work (in both the master and development branch)

Macs-MacBook-Air:ffmpeg mac$ ./android.sh --speed --enable-gpl --full

Building mobile-ffmpeg library for Android

Architectures: arm-v7a-neon, arm64-v8a, x86, x86-64
Libraries: android-zlib, android-media-codec, fontconfig, freetype, fribidi, gmp, gnutls, lame, libass, libiconv, libtheora, libvorbis, libvpx, libwebp, libxml2, opencore-amr, shine, speex, wavpack, kvazaar, libilbc, opus, snappy, soxr, libaom, chromaprint, twolame, sdl, tesseract, openh264

Building arm-v7a-neon platform on API level 24

^C
Macs-MacBook-Air:ffmpeg mac$ ./android.sh --speed --enable-gpl --full --enable-rubberband --enable-libvidstab --enable-x264 --enable-x265 --enable-xvidcore 

Building mobile-ffmpeg library for Android

Architectures: arm-v7a-neon, arm64-v8a, x86, x86-64
Libraries: android-zlib, android-media-codec, fontconfig, freetype, fribidi, gmp, gnutls, lame, libass, libiconv, libtheora, libvorbis, libvpx, libwebp, libxml2, opencore-amr, shine, speex, wavpack, kvazaar, x264, xvidcore, x265, libvidstab, rubberband, libilbc, opus, snappy, soxr, libaom, chromaprint, twolame, sdl, tesseract, openh264

Building arm-v7a-neon platform on API level 24

^C
Macs-MacBook-Air:ffmpeg mac$
tanersener commented 4 years ago 
taner@MERA mobile-ffmpeg % git checkout development                
Already on 'development'
Your branch is up to date with 'origin/development'.
taner@MERA mobile-ffmpeg % git pull                                
Already up to date.
Current branch development is up to date.
taner@MERA mobile-ffmpeg % git describe --tags                     
v4.3.2-23-g9df1b5263
taner@MERA mobile-ffmpeg % ./android.sh --speed --enable-gpl --full

Building mobile-ffmpeg library for Android

Architectures: arm-v7a-neon, arm64-v8a, x86, x86-64
Libraries: android-zlib, android-media-codec, fontconfig, freetype, fribidi, gmp, gnutls, lame, libass, libiconv, libtheora, libvorbis, libvpx, libwebp, libxml2, opencore-amr, shine, speex, wavpack, kvazaar, x264, xvidcore, x265, libvidstab, rubberband, libilbc, opus, snappy, soxr, libaom, chromaprint, twolame, sdl, tesseract, openh264, vo-amrwbenc
github-actions[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

tanersener commented 4 years ago

Released in v4.4.