search

tanersener / mobile-ffmpeg

FFmpeg for Android, iOS and tvOS. Not maintained anymore. Superseded by FFmpegKit.
https://tanersener.github.io/mobile-ffmpeg
GNU General Public License v3.0
3.87k stars 791 forks source link

build/ ignored by default in android studio #532

Closed mgood7123 closed 4 years ago

mgood7123 commented 4 years ago

by default, android studio creates a .gitignore file during the initialization of git vcs that excludes the build/ folder in all subdirectories, this includes ffmpeg git clones, could you consider renaming the directory?

This might also happen in intellij idea, I'm not sure if idea creates a .gitignore or not

tanersener commented 4 years ago

I don't get which directory you're referring to. Could you please be more specific about you expect and what happens right now?

mgood7123 commented 4 years ago

I don't get which directory you're referring to. Could you please be more specific about you expect and what happen right now?

The top level build directory of this repository

https://github.com/tanersener/mobile-ffmpeg/tree/master/build

This will get ignored by git add -Av in an Android Studio Project in which ffmpeg provided as a embedded hard copy (eg without mobile-ffmpeg/.git and related)

As well as Android Studio's built-in vcs git tools

tanersener commented 4 years ago

Correct me if I'm wrong. You have a project layout in which you're including some parts of this repository. In that layout, build directory is ignored by Android Studio, not by shell. So, you want the build directory renamed?

mgood7123 commented 4 years ago

Correct me if I'm wrong. You have a project layout in which you're including some parts of this repository. In that layout, build directory is ignored by Android Studio, not by shell. So, you want the build directory renamed?

Yes, and if by shell you mean, like executing git add in a terminal with the current directory set to the android project then yes it is ignored unless explicitly added, eg

$ git add mobile-ffmpeg/build #explicitly overwrite gitignore rule temporarily for this command invocation

tanersener commented 4 years ago

There are several changes planned for the next release, renaming build directory is one of them.

github-actions[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.