search

tanersener / mobile-ffmpeg

FFmpeg for Android, iOS and tvOS. Not maintained anymore. Superseded by FFmpegKit.
https://tanersener.github.io/mobile-ffmpeg
GNU General Public License v3.0
3.85k stars 787 forks source link

👷 Add `--speed` to android.sh CUSTOM_OPTIONS #633

Closed roblav96 closed 3 years ago

roblav96 commented 3 years ago

Why?

To replicate the same FFprobe output produced by the FFmpeg binaries found on their download page as close as possible.

What?

Currently, the mobile-ffmpeg published gradle packages prioritize bundle output file size while sacrificing some common details one might normally find in an FFprobe output.

For example,

Using implementation 'com.arthenica:mobile-ffmpeg-full:4.4' an FFprobe output is missing these properties:

■ profile and codec_long_name both used to describe

Solution A

Rename the --speed option to --size and flip flop the two defaults? 🤷‍♂️ Idk I feel like not too many people are worried about saving a few Mb's in the year 2021.

Solution B

Publish an additional set of packages adding the speed namespace?

I did try though :D

My attempt at cloning this repo and building the mobile-ffmpeg.aar on my local machine resulted in kernel panics from my logic board overheating. 🔥 Certainly a cleaning well overdue lol

tanersener commented 3 years ago

Solution A

Rename the --speed option to --size and flip flop the two defaults? 🤷‍♂️ Idk I feel like not too many people are worried about saving a few Mb's in the year 2021.

I disagree. I'm already getting too many complaints about the library size. And, this change will increase the size by % 40, https://github.com/tanersener/mobile-ffmpeg/wiki/Speed-Optimization, for all users. Even for users who don't need this feature. I can not approve this change.

Solution B

Publish an additional set of packages adding the speed namespace?

I don't believe the change in this PR is worth publishing a new release. The option is there, please use that option and build your own version.