search

tanersener / mobile-ffmpeg

FFmpeg for Android, iOS and tvOS. Not maintained anymore. Superseded by FFmpegKit.
https://tanersener.github.io/mobile-ffmpeg
GNU General Public License v3.0
3.85k stars 787 forks source link

Github action for CI #660

Closed hannesa2 closed 3 years ago

hannesa2 commented 3 years ago

I see you don't have a CI for this repo. Here is at least a pull request check for Android.

hannesa2 commented 3 years ago

This is a first pre-task for other Android improvements

tanersener commented 3 years ago

This project uses Travis CI. There is a .travis.yml file in the project root directory. It covers both build types of Android, iOS and tvOS.

Any reason to switch to another CI?

hannesa2 commented 3 years ago

Yes, because Travis is not running see eg https://github.com/tanersener/mobile-ffmpeg/pull/654. Github actions are much faster and with it you can run Espresso out of the box

tanersener commented 3 years ago

Yes, because Travis is not running see eg #654.

How could this be a reason to switch to another CI? We don't see anything running for PRs because only master and development branches are enabled in .travis.yml file.

Github actions are much faster

Based on what? Jobs defined in this CI workflow only runs a single gradle command. Contrarily, jobs inside .travis.yaml file runs the actual build scripts (android.sh, ios.sh, tvos.sh). Don't we need to have the same CI build steps defined for Github Actions as well before coming to the conclusion that one of them is faster than the other?

If I see that Github Actions is capable of running the same build jobs faster than Travis, I'll be happy to review and merge that PR. But in this PR I don't see these. I can't approve this.

hannesa2 commented 3 years ago

I see the spirit here. Let's stuck on Travis