search

tanersener / mobile-ffmpeg

FFmpeg for Android, iOS and tvOS. Not maintained anymore. Superseded by FFmpegKit.
https://tanersener.github.io/mobile-ffmpeg
GNU General Public License v3.0
3.85k stars 787 forks source link

Rename Android lib #661

Closed hannesa2 closed 3 years ago

hannesa2 commented 3 years ago

Your Android library has the name app. Sorry, this is misleading and kind of wrong, now it looks better (in my point of view)

Before

image

New

image

This pull request is based on #660 to have a CI build for it

hannesa2 commented 3 years ago

But now I'm confused: You don't use it directly, only the artifact which is previous generated ? Or from where does this implementation 'com.arthenica:mobile-ffmpeg-full:4.4.LTS' comes from ?

image
tanersener commented 3 years ago

Or from where does this implementation 'com.arthenica:mobile-ffmpeg-full:4.4.LTS' comes from ?

It comes from jcenter().

Test application is used to test both the local build and the artifact published to jcenter(). We can not have both of these dependencies enabled at the same time. So, I'm enabling the dependency I want to test before the test.

hannesa2 commented 3 years ago

It's an easy step, but produces a lot of changes. You see what I suggest and I guess you trust yourself most, so I close this and you can do, it don't do it

tanersener commented 3 years ago

Actually, it was possible to merge this. The only problem was the changes coming from your other PR, the one about Github Actions. That's why it wasn't merged.

If you create it again targeting the development branch, without Github Actions, it can be reviewed and merged.