Wrap common settings under HdBbRPrim

tangent-opensource / hdBlackbird

Blackbird Hydra Delegate

Apache License 2.0

298 stars 36 forks source link

Wrap common settings under HdBbRPrim #229

Closed bareya closed 3 years ago

bareya commented 3 years ago

Remove code duplication and slide new HdBbRPrim class under mesh, points and curves. HdBbRPrim carries helper methods to manage object properties.

boberfly commented 3 years ago

Hey @bareya this is great! The de-duplication of code will make it less error-prone and it looks like xforms can have visibility flags with their children inheriting those values correctly which didn't work before.

Instancing/prototypes seems to not work yet (crag asset doesn't have the flags working) but this patch didn't break anything, just something that's missing still that didn't work before this patch anyways.