Closed yotamcons closed 2 years ago
Thank you so much for your interest and the great, detailed feedback.
I would be extremely happy to implement your suggestions. This is a terrific issue.
If you would rather make the changes and issue a pull request, we would love to accept it.
Thank you again.
Would love to, only I haven’t done it before. is there a simple guide somewhere/could you DM me with instructions?
yours,
Yotam
On 21 Feb 2022, at 19:40, DV Klopfenstein, PhD @.***> wrote:
Thank you so much for your interest and the great, detailed feedback.
I would be extremely happy to implement your suggestions. This is a terrific issue.
If you would rather make the changes and issue a pull request, we would love to accept it.
Thank you again.
— Reply to this email directly, view it on GitHub https://github.com/tanghaibao/goatools/issues/235#issuecomment-1047108072, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMDQF4FFZVD5Q266BVPFPF3U4J2JNANCNFSM5OT74ESQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you authored the thread.
We are excited and honored that you would like to do your first pull request with GOA TOOLs. Thank you so much for your time and interest and fantastic contribution. We will ensure that your pull request is a successful and pleasant experience.
Your suggestions for changes to the GOA TOOLs open source project are excellent as they are well defined, tight, and will not break anything for so many users.
I liked this step-by-step guide (https://www.dataschool.io/how-to-contribute-on-github/) to contributing to open source projects because it describes the "why" behind each command and how to work with the three repositories in a pull request:
You can find other guides by searching for:
Congratulations on taking this bold first step into the open-source community!
I gave it a go, would love to get feedback: https://github.com/tanghaibao/goatools/pull/236
@yotamcons
Thank you for your contribution! We'll merge it in.
Haibao
Hey there, first of all - thank you for your tool :)
two small things in the README:
conda install -c bioconda goatools
Thank you again :)