tangkong / SSRL-2-2

SSRL-2-2 beamline profile, continuous XAS
0 stars 0 forks source link

Store configuration metadata #3

Open tangkong opened 3 years ago

tangkong commented 3 years ago

Setting components as kind='config' is results in errors, stemming from the collection of these signals.

I'm trying to add configuration attributes to my flyer, and getting errors thrown when collect() tries to gather configuration information. (traceback here) It looks like we're trying to call .items() one too many times? The dictionaries returned by read_configuration() and describe_configuration() look ok to me? (I could be missing something)

Also, I'd expect configuration information to be collected once at the beginning of the run rather than with each collect() call. I don't expect configuration information to change mid run, so is there a reason to do this repeatedly?

tangkong commented 3 years ago

Adding configuration_attrs after instantiation seems to work here