Closed davidsemakula closed 1 year ago
Awesome work @davidsemakula, thanks for your contribution. Will merge once CI passes.
@drewstone thanks 🙂.
Also Just FYI, current CI failures seem unrelated to/and existed before my changes (that's my understanding from looking at this, this and this, it also looks the like the most recently merged PRs didn't pass CI either) - there were a few rustfmt
failures from my changes but I believe I've fixed those with the last 2 "formatting" commits.
In general running cargo fmt
makes a lot of changes to the code base that are unrelated to the changes in this PR so I was hesitant to run it on the whole project as it would make this PR harder to review.
I have all tests running successfully locally, so given the above issues, I don't think I'm best placed to fix the CI issues in this case 🙂.
Summary of changes Changes introduced in this pull request:
NOTE: No changes and/or tests were made/added for related identifiable aborts so those may still contain errors.
Reference issue to close (if applicable)
Closes