tangle-network / dapp

Monorepo for the Tangle ecosystem.
https://app.tangle.tools
Apache License 2.0
29 stars 15 forks source link

fix(tangle-dapp): Fix sort/scroll issues on nomination selection list modal #2430

Closed vutuanlinh2k2 closed 3 months ago

vutuanlinh2k2 commented 3 months ago

Summary of changes

Provide a detailed description of proposed changes.

Proposed area of change

Put an x in the boxes that apply.

Reference issue to close (if applicable)

Specify any issues that can be closed from these changes (e.g. Closes #233).

Screen Recording

If possible provide a screen recording of proposed change.

https://github.com/webb-tools/webb-dapp/assets/69841784/b715317b-0bc8-4ee0-b4ba-ffe48edf7897


Code Checklist

Please be sure to add .stories documentation if any additions are made to libs/webb-ui-components.

netlify[bot] commented 3 months ago

Deploy Preview for tangle-dapp ready!

Name Link
Latest commit f67c99a58c4831f02c0cd3c1d5d32ef3f0dd5449
Latest deploy log https://app.netlify.com/sites/tangle-dapp/deploys/668fe29528b6f900083e5bed
Deploy Preview https://deploy-preview-2430--tangle-dapp.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

vutuanlinh2k2 commented 3 months ago

@AtelyPham I updated the logic to make sure all selected validators always stay on top no matter what field are being sorted

https://github.com/webb-tools/webb-dapp/assets/69841784/4b15abc7-eb1a-43bd-9974-fbea3da1a62a

vutuanlinh2k2 commented 3 months ago

Previously, when users select the validator, it should also be sorted to the top.

CleanShot.2024-07-11.at.19.55.26.mp4

Fixed with the new commit