tangle-network / dapp

Monorepo for the Tangle ecosystem.
https://app.tangle.tools
Apache License 2.0
29 stars 15 forks source link

feat(tangle-dapp): Implement stake & unstake liquifier functionality for EVM-based liquid staking #2500

Closed yurixander closed 1 month ago

yurixander commented 2 months ago

Summary of changes

Provide a detailed description of proposed changes.

Proposed area of change

Put an x in the boxes that apply.

Reference issue to close (if applicable)

Specify any issues that can be closed from these changes (e.g. Closes #233).

Screen Recording

If possible provide a screen recording of proposed change.

https://github.com/user-attachments/assets/ec9ace53-2105-4c7e-919a-7633db124fcc


Code Checklist

Please be sure to add .stories documentation if any additions are made to libs/webb-ui-components.

netlify[bot] commented 2 months ago

Deploy Preview for tangle-dapp ready!

Name Link
Latest commit d8b0f0bd1ff2643e1db7f8fee7e096a130caf61b
Latest deploy log https://app.netlify.com/sites/tangle-dapp/deploys/66c83e3d9dce5d0008ff4943
Deploy Preview https://deploy-preview-2500--tangle-dapp.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

yurixander commented 1 month ago

Nearly ready to submit for review here. Just need to cleanup logic and errors.

drewstone commented 1 month ago

My take is that we should use chain selection for chains and token selection for protocols.

image

Right now it looks like you're conflating chain selection with protocols, which creates unnecessarily many options. Ethereum should be what you select for LINK and it should show all valid tokens for Liquid Staking on Ethereum (LINK, GRAPH, Livepeer, etc.), Polygon would be a chain as well and MATIC on that chain.

If this messes with how the naming conventions are in code we should modify things so its clear on this front. But it should be preserved that we use chains for the label that simiarly says Tangle Parachain/Polkadot/etc.

yurixander commented 1 month ago

Ok gotcha so where it says Chainlink I would instead show the chain (Ethereum Mainnet) and then where it says LINK it would be the token on that chain? @drewstone

drewstone commented 1 month ago

Correct @yurixander. I think that slot is best for chain selection so its clear when you're bridging from one chain to another. Therefore, it can be clear if you're liquid staking and remaining on Ethereum vs bridging to Tangle.

yurixander commented 1 month ago

Correct @yurixander. I think that slot is best for chain selection so its clear when you're bridging from one chain to another. Therefore, it can be clear if you're liquid staking and remaining on Ethereum vs bridging to Tangle.

Makes sense and I agree. I'll implement that in my other PR.