tangle-network / dapp

Monorepo for the Tangle ecosystem.
https://app.tangle.tools
Apache License 2.0
29 stars 15 forks source link

feat(tangle-dapp): Hyperlane Integration #2525

Closed vutuanlinh2k2 closed 1 month ago

vutuanlinh2k2 commented 1 month ago

Summary of changes

Provide a detailed description of proposed changes.

Proposed area of change

Put an x in the boxes that apply.

Reference issue to close (if applicable)

Specify any issues that can be closed from these changes (e.g. Closes #233).

Screen Recording

If possible provide a screen recording of proposed change.

https://github.com/user-attachments/assets/7a950da2-b49b-46cf-a0dd-058fb5f3491d


Code Checklist

Please be sure to add .stories documentation if any additions are made to libs/webb-ui-components.

netlify[bot] commented 1 month ago

Deploy Preview for tangle-dapp ready!

Name Link
Latest commit febaf8dfdb85e6f0b8219d352799cdb49b0f4db0
Latest deploy log https://app.netlify.com/sites/tangle-dapp/deploys/66d99900e1a29f0008ca0815
Deploy Preview https://deploy-preview-2525--tangle-dapp.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

yurixander commented 1 month ago

CI failing πŸ‘€ @vutuanlinh2k2

yurixander commented 1 month ago

@vutuanlinh2k2

Some quick questions here:

Some possible issues:

drewstone commented 1 month ago

Yes @yurixander currently deployments are only on Testnet, Hyperlane should be on mainnet too so we just need to configure it.

devpavan04 commented 1 month ago

QA on the integration!

https://github.com/user-attachments/assets/f0298bdc-d12c-4ac5-ad2f-a90efcd0bfc3

CleanShot 2024-08-30 at 07 39 47

Here's a bug I encountered. See the screen recording below.

https://github.com/user-attachments/assets/94cfd135-0088-4663-92f5-30aa07d9187d

CleanShot 2024-08-30 at 08 31 57

CleanShot 2024-08-30 at 08 37 36

drewstone commented 1 month ago

@devpavan04 can you fix up the items you found in your QA and ready this PR for merging? You're correct that the functionality when on the wrong chain should be to make the button automatically switch chains when the user goes to transact.

devpavan04 commented 1 month ago

https://github.com/user-attachments/assets/5e7f984f-2440-47c9-a31c-2cda810ccf32

CleanShot 2024-09-03 at 12 45 58

CleanShot 2024-09-03 at 12 46 36

https://github.com/user-attachments/assets/999168e2-d650-42ad-8b63-b8c76013d228

CleanShot 2024-09-03 at 12 53 24

AtelyPham commented 1 month ago

Add https://stats.tangle.tools to .lycheeignore to resolve the CI issue, @devpavan04.

drewstone commented 1 month ago

Can we make sure to remove outdated DNS records we’re not using anymore from any Netlify sites too?

On Wed, Sep 4, 2024 at 2:15 PM Trung-Tin Pham @.***> wrote:

Add https://stats.tangle.tools to .lycheeignore https://github.com/webb-tools/webb-dapp/blob/develop/.lycheeignore to resolve the CI issue, @devpavan04 https://github.com/devpavan04.

β€” Reply to this email directly, view it on GitHub https://github.com/webb-tools/webb-dapp/pull/2525#issuecomment-2327938466, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADELLF4Z26Q3PP6O33FXL63ZU2JQVAVCNFSM6AAAAABNGMVNFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRXHEZTQNBWGY . You are receiving this because your review was requested.Message ID: @.***>

AtelyPham commented 1 month ago

Can we make sure to remove outdated DNS records we’re not using anymore from any Netlify sites too? … On Wed, Sep 4, 2024 at 2:15 PM Trung-Tin Pham @.> wrote: Add https://stats.tangle.tools to .lycheeignore <https://github.com/webb-tools/webb-dapp/blob/develop/.lycheeignore> to resolve the CI issue, @devpavan04 https://github.com/devpavan04. β€” Reply to this email directly, view it on GitHub <#2525 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADELLF4Z26Q3PP6O33FXL63ZU2JQVAVCNFSM6AAAAABNGMVNFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRXHEZTQNBWGY . You are receiving this because your review was requested.Message ID: @.>

I'll handle that shortly.