Closed vutuanlinh2k2 closed 1 month ago
Name | Link |
---|---|
Latest commit | febaf8dfdb85e6f0b8219d352799cdb49b0f4db0 |
Latest deploy log | https://app.netlify.com/sites/tangle-dapp/deploys/66d99900e1a29f0008ca0815 |
Deploy Preview | https://deploy-preview-2525--tangle-dapp.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
CI failing π @vutuanlinh2k2
@vutuanlinh2k2
Some quick questions here:
Some possible issues:
undefined
for the symbol:
max
it bypasses the 0 check):
sygUSD
asset's icons are missing:
Yes @yurixander currently deployments are only on Testnet, Hyperlane should be on mainnet too so we just need to configure it.
WETH
from Holesky
to Sepolia
sucessfully β
https://github.com/user-attachments/assets/f0298bdc-d12c-4ac5-ad2f-a90efcd0bfc3
Here's a bug I encountered. See the screen recording below.
Sepolia
to bridge to Holesky
, and the Transfer
button is enabled when I enter an amount and a destination address. β
Roccoco Phala
, where I don't have a sygUSD
balance on Sepolia
, the Transfer
button is correctly disabled. β
Holesky
, where I do have a WETH
balance on Sepolia
. The Transfer
button remains disabled when it should be enabled. β οΈhttps://github.com/user-attachments/assets/94cfd135-0088-4663-92f5-30aa07d9187d
Wrong EVM Chain Connected
, doesn't need to be an error. We should inform the user that the connected chain and the selected source chain do not match, so they need to switch. Additionally, the message could be changed to Wallet and Source Chain Mismatch
, as shown in the second screenshot below.@devpavan04 can you fix up the items you found in your QA and ready this PR for merging? You're correct that the functionality when on the wrong chain should be to make the button automatically switch chains when the user goes to transact.
Add https://stats.tangle.tools
to .lycheeignore to resolve the CI issue, @devpavan04.
Can we make sure to remove outdated DNS records weβre not using anymore from any Netlify sites too?
On Wed, Sep 4, 2024 at 2:15 PM Trung-Tin Pham @.***> wrote:
Add https://stats.tangle.tools to .lycheeignore https://github.com/webb-tools/webb-dapp/blob/develop/.lycheeignore to resolve the CI issue, @devpavan04 https://github.com/devpavan04.
β Reply to this email directly, view it on GitHub https://github.com/webb-tools/webb-dapp/pull/2525#issuecomment-2327938466, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADELLF4Z26Q3PP6O33FXL63ZU2JQVAVCNFSM6AAAAABNGMVNFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRXHEZTQNBWGY . You are receiving this because your review was requested.Message ID: @.***>
Can we make sure to remove outdated DNS records weβre not using anymore from any Netlify sites too? β¦ On Wed, Sep 4, 2024 at 2:15 PM Trung-Tin Pham @.> wrote: Add https://stats.tangle.tools to .lycheeignore <https://github.com/webb-tools/webb-dapp/blob/develop/.lycheeignore> to resolve the CI issue, @devpavan04 https://github.com/devpavan04. β Reply to this email directly, view it on GitHub <#2525 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADELLF4Z26Q3PP6O33FXL63ZU2JQVAVCNFSM6AAAAABNGMVNFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRXHEZTQNBWGY . You are receiving this because your review was requested.Message ID: @.>
I'll handle that shortly.
Summary of changes
Provide a detailed description of proposed changes.
BridgeContext
andBridgeTxQueueContext
Holesky
tochainsConfig
Proposed area of change
Put an
x
in the boxes that apply.apps/bridge-dapp
apps/hubble-stats
apps/stats-dapp
apps/tangle-dapp
apps/testnet-leaderboard
apps/faucet
apps/zk-explorer
libs/webb-ui-components
Reference issue to close (if applicable)
Specify any issues that can be closed from these changes (e.g.
Closes #233
).Screen Recording
If possible provide a screen recording of proposed change.
https://github.com/user-attachments/assets/7a950da2-b49b-46cf-a0dd-058fb5f3491d
Code Checklist
Please be sure to add .stories documentation if any additions are made to
libs/webb-ui-components
.