tangle-network / dkg-substrate

Multy-party threshold ECDSA (GG20) Substrate node
https://tangle.webb.tools/
GNU General Public License v3.0
60 stars 15 forks source link

Update events for ease of relayer operations #669

Closed drewstone closed 1 year ago

drewstone commented 1 year ago

Summary of changes Changes introduced in this pull request:

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 13.34% and project coverage change: -0.17 :warning:

Comparison is base (4578610) 17.10% compared to head (727a0be) 16.92%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #669 +/- ## ========================================== - Coverage 17.10% 16.92% -0.17% ========================================== Files 71 71 Lines 5429 5420 -9 ========================================== - Hits 928 917 -11 - Misses 4501 4503 +2 ``` | [Impacted Files](https://app.codecov.io/gh/webb-tools/dkg-substrate/pull/669?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webb-tools) | Coverage Δ | | |---|---|---| | [dkg-runtime-primitives/src/proposal.rs](https://app.codecov.io/gh/webb-tools/dkg-substrate/pull/669?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webb-tools#diff-ZGtnLXJ1bnRpbWUtcHJpbWl0aXZlcy9zcmMvcHJvcG9zYWwucnM=) | `36.93% <ø> (ø)` | | | [pallets/dkg-metadata/src/benchmarking.rs](https://app.codecov.io/gh/webb-tools/dkg-substrate/pull/669?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webb-tools#diff-cGFsbGV0cy9ka2ctbWV0YWRhdGEvc3JjL2JlbmNobWFya2luZy5ycw==) | `0.00% <ø> (ø)` | | | [pallets/dkg-metadata/src/lib.rs](https://app.codecov.io/gh/webb-tools/dkg-substrate/pull/669?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webb-tools#diff-cGFsbGV0cy9ka2ctbWV0YWRhdGEvc3JjL2xpYi5ycw==) | `34.10% <13.34%> (-0.94%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

drewstone commented 1 year ago

Purpose of this is to update events so transfer process is more seamless for the relayer. We will need to update webb-rs this week @shekohex @1xstj including types. Let's plan to get the new types for these repos also published this week please.

drewstone commented 1 year ago

This also deletes dkg-test-suite. If you object @1xstj @shekohex @tbraun96 please share thoughts. It seems that we spend more time updating and wrangling types to get those tests to work and I'm convinced that this is not productive and that these tests are not needed anymore. They can just be pushed into Solidity unit tests. If we want proper E2E tests let's use Rust moving forward. The webb.js types system is not worth maintaining and we should move all useful libraries there to the protocol-solidity repo.