tangle-network / dkg-substrate

Multy-party threshold ECDSA (GG20) Substrate node
https://tangle.webb.tools/
GNU General Public License v3.0
60 stars 15 forks source link

Generalize the DKGs via modularization #676

Closed tbraun96 closed 1 year ago

tbraun96 commented 1 year ago

Closes #677

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 1.11% and project coverage change: -0.18 :warning:

Comparison is base (90bfe77) 16.10% compared to head (feaaed4) 15.91%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #676 +/- ## ========================================== - Coverage 16.10% 15.91% -0.18% ========================================== Files 73 74 +1 Lines 5412 5475 +63 ========================================== Hits 871 871 - Misses 4541 4604 +63 ``` | [Impacted Files](https://app.codecov.io/gh/webb-tools/dkg-substrate/pull/676?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webb-tools) | Coverage Δ | | |---|---|---| | [dkg-gadget/src/async\_protocols/dkg.rs](https://app.codecov.io/gh/webb-tools/dkg-substrate/pull/676?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webb-tools#diff-ZGtnLWdhZGdldC9zcmMvYXN5bmNfcHJvdG9jb2xzL2RrZy5ycw==) | `0.00% <0.00%> (ø)` | | | [dkg-gadget/src/async\_protocols/mod.rs](https://app.codecov.io/gh/webb-tools/dkg-substrate/pull/676?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webb-tools#diff-ZGtnLWdhZGdldC9zcmMvYXN5bmNfcHJvdG9jb2xzL21vZC5ycw==) | `0.00% <ø> (ø)` | | | [dkg-gadget/src/gossip\_engine/network.rs](https://app.codecov.io/gh/webb-tools/dkg-substrate/pull/676?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webb-tools#diff-ZGtnLWdhZGdldC9zcmMvZ29zc2lwX2VuZ2luZS9uZXR3b3JrLnJz) | `0.00% <0.00%> (ø)` | | | [dkg-gadget/src/keygen\_manager/mod.rs](https://app.codecov.io/gh/webb-tools/dkg-substrate/pull/676?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webb-tools#diff-ZGtnLWdhZGdldC9zcmMva2V5Z2VuX21hbmFnZXIvbW9kLnJz) | `0.00% <0.00%> (ø)` | | | [dkg-gadget/src/lib.rs](https://app.codecov.io/gh/webb-tools/dkg-substrate/pull/676?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webb-tools#diff-ZGtnLWdhZGdldC9zcmMvbGliLnJz) | `0.00% <0.00%> (ø)` | | | [dkg-gadget/src/signing\_manager/mod.rs](https://app.codecov.io/gh/webb-tools/dkg-substrate/pull/676?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webb-tools#diff-ZGtnLWdhZGdldC9zcmMvc2lnbmluZ19tYW5hZ2VyL21vZC5ycw==) | `0.00% <0.00%> (ø)` | | | [dkg-gadget/src/worker.rs](https://app.codecov.io/gh/webb-tools/dkg-substrate/pull/676?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webb-tools#diff-ZGtnLWdhZGdldC9zcmMvd29ya2VyLnJz) | `0.00% <0.00%> (ø)` | | | [dkg-primitives/src/utils.rs](https://app.codecov.io/gh/webb-tools/dkg-substrate/pull/676?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webb-tools#diff-ZGtnLXByaW1pdGl2ZXMvc3JjL3V0aWxzLnJz) | `35.60% <0.00%> (+1.73%)` | :arrow_up: | | [dkg-test-orchestrator/src/client.rs](https://app.codecov.io/gh/webb-tools/dkg-substrate/pull/676?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webb-tools#diff-ZGtnLXRlc3Qtb3JjaGVzdHJhdG9yL3NyYy9jbGllbnQucnM=) | `0.00% <ø> (ø)` | | | [dkg-test-orchestrator/src/dummy\_api.rs](https://app.codecov.io/gh/webb-tools/dkg-substrate/pull/676?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webb-tools#diff-ZGtnLXRlc3Qtb3JjaGVzdHJhdG9yL3NyYy9kdW1teV9hcGkucnM=) | `0.00% <ø> (ø)` | | | ... and [4 more](https://app.codecov.io/gh/webb-tools/dkg-substrate/pull/676?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webb-tools) | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

tbraun96 commented 1 year ago

LGTM, this is entirely backwards compatible right?

Yes, this will work with our current system. We never trigger the newer system since it's left unimplemented and never used.