tangle-network / protocol-substrate

Webb protocol implementation in Substrate.
https://docs.webb.tools/v1/anchor-system/overview/
Apache License 2.0
37 stars 11 forks source link

Anonymity mining claims pallet update #303

Closed semaraugusto closed 1 year ago

semaraugusto commented 1 year ago

Summary of changes Changes introduced in this pull request: Updates anonimity-mining-claims pallet.

Reference issue to close (if applicable)

Closes https://github.com/webb-tools/protocol-substrate/issues/299

drewstone commented 1 year ago

Worth trying but should be possible. Just have to pass in a single instance to the non instance pallet.

On Sat, Mar 11, 2023 at 8:36 AM Akilesh Tangella @.***> wrote:

@.**** commented on this pull request.

In pallets/anonymity-mining-claims/src/mock.rs https://github.com/webb-tools/protocol-substrate/pull/303#discussion_r1133109336 :

    TokenWrapper: pallet_token_wrapper::{Pallet, Call, Storage, Event<T>},

KeyStorage: pallet_key_storage::{Pallet, Call, Storage, Event, Config},

  • AnonymityMiningClaims: pallet_anonymity_mining_claims::{Pallet, Call, Storage, Event, Config}
  • AnonymityMiningClaims: pallet_anonymity_mining_claims::::{Pallet, Call, Storage, Event, Config}

Can a non-instanceable pallet take in an instanceable pallet in its Config trait. Because we take in a VAnchor type that represents the APVAnchor and pallet_vanchor is instanceable?

— Reply to this email directly, view it on GitHub https://github.com/webb-tools/protocol-substrate/pull/303#discussion_r1133109336, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADELLF3ZG46NGUDJS3J5TGTW3SLXFANCNFSM6AAAAAAVW3E6TM . You are receiving this because you commented.Message ID: @.***>

akileshtangella commented 1 year ago

@drewstone I'm in favor of merging this. There was a bit trouble getting the benchmarks done, but at least the claims pallet verifier is working. I want @semaraugusto to move onto some other tasks. WDYT?

drewstone commented 1 year ago

Sounds fine to me. Please make tasks to track benchmarking separately so we can add to future sprints. @saiakilesh.

akileshtangella commented 1 year ago

Sounds fine to me. Please make tasks to track benchmarking separately so we can add to future sprints. @saiakilesh.

Will do