tangle-network / relayer

🕸️ The Webb Relayer Network
https://webb-tools.github.io/relayer/
Apache License 2.0
22 stars 13 forks source link

Substrate governor update #371

Closed salman01zp closed 1 year ago

salman01zp commented 1 year ago

Summary of changes

Reference issue to close (if applicable)

salman01zp commented 1 year ago

We will need to force set maintainer nonce too along with maintainer/governor. I have drafted a PR for it here.

salman01zp commented 1 year ago

will need to update protocol-substrate-types and rust bindings in webb-rs.

shekohex commented 1 year ago

We will need to force set maintainer nonce too along with maintainer/governor. I have drafted a PR for it here.

This PR is now merged!

shekohex commented 1 year ago

will need to update protocol-substrate-types and rust bindings in webb-rs.

the PR is up here https://github.com/webb-tools/webb-rs/pull/125

Nutomic commented 1 year ago

It seems that this change broke integration tests, this is what I get on develop:

yarn && yarn test

TSError: ⨯ Unable to compile TypeScript:
test/evm/evmToSubstrateTransaction.test.ts:298:78 - error TS2554: Expected 7 arguments, but got 8.

298     await vanchor1.transact([], [depositUtxo], 0, 0, '0', '0', tokenAddress, {
~
299       [typedSourceChainId]: leaves,
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
300     });
~~~~~
test/evm/evmToSubstrateTransaction.test.ts:331:7 - error TS2345: Argument of type 'import("/home/felix/workspace/webb/relayer/tests/node_modules/@webb-tools/test-utils/node_modules/@webb-tools/anchors/lib/VAnchor").VAnchor' is not assignable to parameter of type 'import("/home/felix/workspace/webb/relayer/tests/node_modules/@webb-tools/anchors/lib/VAnchor").VAnchor'.
Type 'VAnchor' is missing the following properties from type 'VAnchor': leafCreatedAtBlock, updateTreeOrForestState, generateProof, register, and 14 more.

331       vanchor1,
~~~~~~~~

at createTSError (/home/felix/workspace/webb/relayer/tests/node_modules/ts-node/src/index.ts:859:12)
at reportTSError (/home/felix/workspace/webb/relayer/tests/node_modules/ts-node/src/index.ts:863:19)
at getOutput (/home/felix/workspace/webb/relayer/tests/node_modules/ts-node/src/index.ts:1077:36)
at Object.compile (/home/felix/workspace/webb/relayer/tests/node_modules/ts-node/src/index.ts:1433:41)
at transformSource (/home/felix/workspace/webb/relayer/tests/node_modules/ts-node/src/esm.ts:400:37)
at /home/felix/workspace/webb/relayer/tests/node_modules/ts-node/src/esm.ts:278:53
at async addShortCircuitFlag (/home/felix/workspace/webb/relayer/tests/node_modules/ts-node/src/esm.ts:409:15)
at async nextLoad (node:internal/modules/esm/loader:163:22)
at async ESMLoader.load (node:internal/modules/esm/loader:605:20)
at async ESMLoader.moduleProvider (node:internal/modules/esm/loader:457:11)
at async link (node:internal/modules/esm/module_job:67:21)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Edit: Getting even more errors after I comment these lines out. Gonna work on the previous commit for now.

salman01zp commented 1 year ago

did you try yarn install?

Nutomic commented 1 year ago

Just tried it, same errors as before.

salman01zp commented 1 year ago

Clearning node modules, cache, and reinstalling should fix it.