Substrate code cleanup - Githubissues

tangle-network / relayer

🕸️ The Webb Relayer Network

https://webb-tools.github.io/relayer/

Apache License 2.0

22 stars 13 forks source link

Substrate code cleanup #554

Closed salman01zp closed 1 year ago

salman01zp commented 1 year ago

Summary of changes

[x] Remove substrate event watchers for Vanchor and Signature bridge
[x] Remove Private tx relaying for substrate
[x] Remove substrate API services
[x] Remove substrate config for Vanchor and Signature bridge pallets
[x] Remove bridge watcher trait

Reference issue to close (if applicable)

Closes

Code Checklist

[ ] Tested
[ ] Documented

shekohex commented 1 year ago

@salman01zp is this now ready to review? is there any other cleanup things we should consider?

salman01zp commented 1 year ago

I have removed almost everything related to the substrate(vanchor/signature bridge around). Looking into why the tests are not passing, but else is good to review

shekohex commented 1 year ago

I have removed almost everything related to the substrate(vanchor/signature bridge around).

Good

Looking into why the tests are not passing, but else is good to review

Is it passing locally? Which one is failing?

shekohex commented 1 year ago

In 640bd15 (#554) you removed substrate tx queue! we still need that for DKG Transactions. so @salman01zp could you please bring this back.

shekohex commented 1 year ago

Fixed the substrate tx queue errors and improved the tx dry-run failure detection. this should be ready very soon.