tangle-network / tangle-mpc-sdk

0 stars 0 forks source link

feat: Adding submitJob function and types #7

Closed AtelyPham closed 6 months ago

AtelyPham commented 6 months ago

Summary of changes

AtelyPham commented 6 months ago

There are still two issues on the pull request that need to be addressed before it is ready for review:

  1. The tangle-substrate-types package needs to be published with the fixes from PR https://github.com/webb-tools/tangle/pull/572. Currently, it is using the local package.
  2. There is a testing error with jest: Jest has detected the following 1 open handle potentially preventing Jest from exiting.

CleanShot 2024-03-21 at 20 39 14@2x

salman01zp commented 6 months ago

https://github.com/webb-tools/relayer/blob/main/tests/lib/substrateNodeBase.ts This might help you seting up a local node for testing.

AtelyPham commented 6 months ago

webb-tools/relayer@main/tests/lib/substrateNodeBase.ts This might help you seting up a local node for testing.

Thanks 🙏 I'll handle this on a separate PR.

salman01zp commented 6 months ago

I opened up PR for setting up the Local test node. I ran into some Esm loader issues and need some fixing Maybe you can merge that into this PR and update your tests

https://github.com/webb-tools/tangle-mpc-sdk/pull/8

drewstone commented 6 months ago

@salman01zp can you fix up the merge conflicts in these PRs so we can merge. I merged your PR in first and it led to this.

AtelyPham commented 6 months ago

@salman01zp can you fix up the merge conflicts in these PRs so we can merge. I merged your PR in first and it led to this.

I'll give it a shot 👀