search

tango-controls-hdbpp / libhdbpp-mysql

Library for HDB++ implementing MySQL schema. Moved to https://gitlab.com/tango-controls/hdbpp/libhdbpp-mysql
http://www.tango-controls.org/community/projects/hdbplus
1 stars 4 forks source link

Project build and Batch insert #13

Closed gscalam closed 3 years ago

gscalam commented 3 years ago

Implements cmake based build compatible with hdbpp "project-build" and batch insertion.

dlacoste-esrf commented 3 years ago

Concerning the mariadb compatibility, it is needed to change line 50 of CMakeLists.txt, as this is only looking for mysqlclient. We could use pkg_search_module instead of the pkg_check_modules, and add mariadb to ensure one or the other is found.

gscalam commented 3 years ago

Trying to fix checking of installed mysql/mariadb libraries. By the way on debian, libmariadb-dev-compat package installs symbolic links to be compatible with client looking for MySQL libraries.

gscalam commented 3 years ago

It's a light code review as I didn't set up a full mysql environment to perform real tests. But from reading the code, it seems good to me !

OK, thanks!