tango-controls / JTango

TANGO kernel Java implementation. JTango moved to https://gitlab.com/tango-controls/JTango
http://tango-controls.org
8 stars 14 forks source link

fr.esrf.TangoApi.DbDevExportInfo class not taking into account pid parameter #30

Closed bourtemb closed 7 years ago

bourtemb commented 7 years ago

fr.esrf.TangoApi.Database.export_device method is taking a DbDevExportInfo object as parameter. toStringArray() method is then invoked on this object (in fr.esrf.TangoApi.DatabaseDAODefaultImpl.export_device() method). The resulting string array is then passed to DbExportDevice command which is executed on the Database server object.

The Database server is expecting the following arguments, in this order in the String array argin:

The problem is fr.esrf.TangoApi.DatabaseDAODefaultImpl.export_device() is not passing the arguments expected by the database server for this command. DbDevExportInfo.toStringArray() method is creating a string array with the following cells:

There seems to be an inconsistency in jtango because there is another class named org.tango.client.database.DeviceExportInfo which seems very similar to fr.esrf.TangoApi.DbDevExportInfo class and used by org.tango.client.database.Datavase.exportDevice() method but taking into account correctly the pid parameter.

Ingvord commented 7 years ago

@bourtemb thanks for the detailed report!