search

tango-controls / JTango

TANGO kernel Java implementation. JTango moved to https://gitlab.com/tango-controls/JTango
http://tango-controls.org
8 stars 14 forks source link

Update PollStatusCommand.java #45

Closed Ingvord closed 5 years ago

Ingvord commented 7 years ago

Because you can always do it in a better way

getPollStatuses returns a collection thus better fits in Functional Programming paradigm

buildPossStatus has been refactored to use templates rather then code

codecov[bot] commented 7 years ago

Codecov Report

Merging #45 into master will decrease coverage by 0.03%. The diff coverage is 80.95%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #45      +/-   ##
============================================
- Coverage     25.47%   25.44%   -0.04%     
  Complexity     1503     1503              
============================================
  Files           302      302              
  Lines         20712    20704       -8     
  Branches       2342     2346       +4     
============================================
- Hits           5277     5268       -9     
  Misses        14972    14972              
- Partials        463      464       +1
Impacted Files Coverage Δ Complexity Δ
...java/org/tango/server/admin/PollStatusCommand.java 80% <80.95%> (-4.91%) 12 <6> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8b29fec...13fe9be. Read the comment docs.