search

tango-controls / JTango

TANGO kernel Java implementation. JTango moved to https://gitlab.com/tango-controls/JTango
http://tango-controls.org
8 stars 14 forks source link

remove idl module #77

Closed Ingvord closed 5 years ago

Ingvord commented 5 years ago

Resolves #69

Ingvord commented 5 years ago

We need to wait till tango-idl is synced with maven central before travis build passes

Ingvord commented 5 years ago

Concerning syncing tango-idl we need further discussion, as it is not possible to delete the old one, as it is already linked to JCenter i.e. made public

Hi ingvord,

As we informed we can only approve one path for a single package. If you would like to add a new package in Jcenter, kindly raise a new JCenter inclusion request with a different path.

The path you requested "org/tango-controls/tango-idl" is already included in JCenter. Once the package is added to JCenter, it is made due to a possible use as a dependency by other users in their builds hence we would not be able to delete the path from JCenter.

If you would send a new inclusion request with a different path (Other than "org/tango-controls/tango-idl" ), we would be glad to approve your request.

I hope the above information clarifies your question, Kindly get back to us in case if you need any further assistance.

Best regards,
Janardhana JL
JFrog Support

Maybe we can upload missing files to the existing versions (-sources.jar, -javadoc.jar) and try to sync with maven central

OR

change the path e.g. org.tango-controls:tango-idl -> org.tango-controls:jtango-idl

I would prefer the later one, as the first one will at most probably fail due to GPG signature

codecov[bot] commented 5 years ago

Codecov Report

Merging #77 into jtango-9-lts will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             jtango-9-lts      #77   +/-   ##
===============================================
  Coverage           25.65%   25.65%           
  Complexity           1547     1547           
===============================================
  Files                 312      312           
  Lines               21406    21406           
  Branches             2395     2395           
===============================================
  Hits                 5491     5491           
  Misses              15452    15452           
  Partials              463      463

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c9135e2...b5e4485. Read the comment docs.

Ingvord commented 5 years ago

New artifactId has been set (see tango-idl#9) and synced with maven central. All checks are green now!