Prepare release 9.3.4

[bourtemb]

Task list:

• [x] Read/review steps listed in the "Releasing a new version" documentation for making a release
• [x] Bump the version (if not already done) on 9.3-backports branch
• [x] Merge the wished Pull Requests into 9.3-backports (Make sure Travis and appveyor are OK on the PR before the merge)
• [x] Make sure the documentation is updated (readthedocs, doxygen)
• [x] Make sure Travis and appveyor are OK on 9.3-backports branch
• [x] Edit the CHANGELOG.md file
• [x] Edit the RELEASE_NOTES file
• [x] Create a release tag on GitHub, from 9.3-backports branch. Flag it as a pre-release.
• [x] Advertise the pre-release on the mailing list to ask for feedback and testers
• [x] Wait for at least 2 weeks before to do the next steps to give some time to get feedback from the first testers
• [x] If no major bug was reported, the GitHub release can be flagged as "Latest release", else the bugs should be fixed first and a new pre-release should be created.
• [x] Add Windows installers as assets to the GitHub release
• [x] Generate Doxygen documentation for this new release and update cppTango-docs with the new generated documentation (https://github.com/tango-controls/cppTango-docs/pull/2)
• [x] Update cppTango version in TangoSourceDistribution repository (https://github.com/tango-controls/TangoSourceDistribution/pull/53)
• [x] Release a new version of the TangoSourceDistribution
• [x] Update the upgrade scripts in the TangoDatabase repository (https://github.com/tango-controls/TangoDatabase/pull/19)
• [ ] Upgrade tango-cs docker and eventually tango-db docker (if a new version of TangoDatabase has been released).
• [ ] Advertise the release as the new stable release on the mailing list and on the tango-controls website (News)
• [ ] Close this issue

[picca]

while working on the packaging I got these error messages via lintian

warning: the authors of lintian do not recommend running it with root privileges!
P: tango source: source-contains-prebuilt-flash-object doc/html/_static/astor_new_server_wizard.swf
E: tango source: source-is-missing doc/html/_static/astor_new_server_wizard.swf
P: tango source: insane-line-length-in-source-file doc/html/_static/jquery.js line length is 32033 characters (>512)
P: tango source: source-contains-prebuilt-javascript-object doc/html/_static/jquery.js line length is 32033 characters (>512)
E: tango source: source-is-missing doc/html/_static/jquery.js line length is 32033 characters (>512)
P: tango source: insane-line-length-in-source-file doc/html/_static/underscore.js line length is 519 characters (>512)
P: tango source: source-contains-prebuilt-javascript-object doc/html/_static/underscore.js line length is 519 characters (>512)
E: tango source: source-is-missing doc/html/_static/underscore.js line length is 519 characters (>512)
P: tango source: source-contains-prebuilt-javascript-object doc/html/_static/js/modernizr.min.js
E: tango source: source-is-missing doc/html/_static/js/modernizr.min.js
P: tango source: source-contains-prebuilt-javascript-object doc/html/_static/js/theme.js line length is 505 characters (>256)
E: tango source: source-is-missing doc/html/_static/js/theme.js line length is 505 characters (>256)
P: tango source: source-contains-prebuilt-flash-object doc/src/source/_static/astor_new_server_wizard.swf
E: tango source: source-is-missing doc/src/source/_static/astor_new_server_wizard.swf
P: tango source: package-does-not-install-examples doc/src/source/development/client-api/atk/examples/
P: tango source: source-contains-prebuilt-javascript-object doc/src/source/_theme/sphinx_rtd_theme/static/js/modernizr.min.js
E: tango source: source-is-missing doc/src/source/_theme/sphinx_rtd_theme/static/js/modernizr.min.js
P: tango source: source-contains-prebuilt-javascript-object doc/src/source/_theme/sphinx_rtd_theme/static/js/theme.js line length is 505 characters (>256)
E: tango source: source-is-missing doc/src/source/_theme/sphinx_rtd_theme/static/js/theme.js line length is 505 characters (>256)
W: tango source: sphinxdoc-but-no-sphinxdoc-depends
P: tango source: rules-requires-root-missing
I: tango source: wildcard-matches-nothing-in-dep5-copyright lib/cpp/client/zmq.hpp (paragraph at line 15)
W: tango source: global-files-wildcard-not-first-paragraph-in-dep5-copyright (paragraph at line 24)
I: tango source: unused-file-paragraph-in-dep5-copyright paragraph at line 11
I: tango source: unused-file-paragraph-in-dep5-copyright paragraph at line 15
I: tango source: unused-file-paragraph-in-dep5-copyright paragraph at line 19
I: tango source: unused-file-paragraph-in-dep5-copyright paragraph at line 7
I: tango source: debian-rules-parses-dpkg-parsechangelog (line 7)
I: tango source: debian-rules-parses-dpkg-parsechangelog (line 8)
I: tango source: out-of-date-standards-version 4.3.0 (released 2018-12-23) (current is 4.4.1)
W: tango source: spelling-error-in-patch-description debian/patches/0003-use-pkg-config-for-zlib.patch trailling trailing
I: tango source: testsuite-autopkgtest-missing
I: tango-starter: spelling-error-in-binary usr/lib/tango/Starter catched caught
I: tango-starter: spelling-error-in-binary usr/lib/tango/Starter controled controlled
I: tango-starter: spelling-error-in-binary usr/lib/tango/Starter registred registered
I: tango-starter: spelling-error-in-binary usr/lib/tango/Starter automaticly automatically
W: tango-starter: skip-systemd-native-flag-missing-pre-depends prerm:5
W: tango-starter: skip-systemd-native-flag-missing-pre-depends postinst:12
P: tango-starter: missing-systemd-service-for-init.d-script tango-starter
I: libtango-tools: extended-description-is-probably-too-short
W: liblog4tango5v5-dbgsym: debug-file-with-no-debug-symbols usr/lib/debug/.build-id/a4/da39b09f617e1e36f92d5467da684dd8459fe9.debug
I: tango-accesscontrol: hardening-no-fortify-functions usr/lib/tango/TangoAccessControl
W: tango-accesscontrol: skip-systemd-native-flag-missing-pre-depends postinst:12
W: tango-accesscontrol: skip-systemd-native-flag-missing-pre-depends prerm:5
P: tango-accesscontrol: missing-systemd-service-for-init.d-script tango-accesscontrol
I: tango-db: spelling-error-in-binary usr/lib/tango/DataBaseds Propery Property
I: tango-db: spelling-error-in-binary usr/lib/tango/DataBaseds reseting resetting
W: tango-db: no-debconf-templates
W: tango-db: skip-systemd-native-flag-missing-pre-depends postinst:26
W: tango-db: skip-systemd-native-flag-missing-pre-depends prerm:11
P: tango-db: missing-systemd-service-for-init.d-script tango-db
W: liblog4tango5v5: shared-lib-without-dependency-information usr/lib/x86_64-linux-gnu/liblog4tango.so.5.0.2
I: liblog4tango5v5: no-symbols-control-file usr/lib/x86_64-linux-gnu/liblog4tango.so.5.0.2
I: liblog4tango-doc: spelling-error-in-manpage usr/share/man/man3/log4tango::Appender.3.gz occured occurred
I: liblog4tango-doc: spelling-error-in-manpage usr/share/man/man3/log4tango::OstreamAppender.3.gz occured occurred
I: liblog4tango-doc: spelling-error-in-manpage usr/share/man/man3/log4tango::StringUtil.3.gz contructed constructed
I: liblog4tango-doc: spelling-error-in-manpage usr/share/man/man3/log4tango::StringUtil.3.gz contructed constructed
W: liblog4tango-doc: manpage-has-bad-whatis-entry usr/share/man/man3/log4tango.3.gz
W: liblog4tango-doc: manpage-has-bad-whatis-entry usr/share/man/man3/log4tango::Appender.3.gz
W: liblog4tango-doc: manpage-has-bad-whatis-entry usr/share/man/man3/log4tango::AppenderAttachable.3.gz
W: liblog4tango-doc: manpage-has-bad-whatis-entry usr/share/man/man3/log4tango::FileAppender.3.gz
W: liblog4tango-doc: manpage-has-bad-whatis-entry usr/share/man/man3/log4tango::FormatModifierComponent.3.gz
W: liblog4tango-doc: manpage-has-bad-whatis-entry usr/share/man/man3/log4tango::Layout.3.gz
W: liblog4tango-doc: manpage-has-bad-whatis-entry usr/share/man/man3/log4tango::LayoutAppender.3.gz
W: liblog4tango-doc: manpage-has-bad-whatis-entry usr/share/man/man3/log4tango::Level.3.gz
W: liblog4tango-doc: manpage-has-bad-whatis-entry usr/share/man/man3/log4tango::LevelComponent.3.gz
W: liblog4tango-doc: manpage-has-bad-whatis-entry usr/share/man/man3/log4tango::LogInitiator.3.gz
W: liblog4tango-doc: manpage-has-bad-whatis-entry usr/share/man/man3/log4tango::LogSeparator.3.gz
W: liblog4tango-doc: manpage-has-bad-whatis-entry usr/share/man/man3/log4tango::LogStream.3.gz
W: liblog4tango-doc: manpage-has-bad-whatis-entry usr/share/man/man3/log4tango::LogStreamBuf.3.gz
W: liblog4tango-doc: manpage-has-bad-whatis-entry usr/share/man/man3/log4tango::Logger.3.gz
W: liblog4tango-doc: manpage-has-bad-whatis-entry usr/share/man/man3/log4tango::LoggerNameComponent.3.gz
W: liblog4tango-doc: manpage-has-bad-whatis-entry usr/share/man/man3/log4tango::LoggerStream.3.gz
W: liblog4tango-doc: manpage-has-bad-whatis-entry usr/share/man/man3/log4tango::MessageComponent.3.gz
W: liblog4tango-doc: manpage-has-bad-whatis-entry usr/share/man/man3/log4tango::MillisSinceEpochComponent.3.gz
W: liblog4tango-doc: manpage-has-bad-whatis-entry usr/share/man/man3/log4tango::OstreamAppender.3.gz
W: liblog4tango-doc: manpage-has-bad-whatis-entry usr/share/man/man3/log4tango::PatternLayout.3.gz
W: liblog4tango-doc: manpage-has-bad-whatis-entry usr/share/man/man3/log4tango::PatternLayout::PatternComponent.3.gz
W: liblog4tango-doc: manpage-has-bad-whatis-entry usr/share/man/man3/log4tango::ProcessorTimeComponent.3.gz
W: liblog4tango-doc: manpage-has-bad-whatis-entry usr/share/man/man3/log4tango::RollingFileAppender.3.gz
W: liblog4tango-doc: manpage-has-bad-whatis-entry usr/share/man/man3/log4tango::SecondsSinceEpochComponent.3.gz
W: liblog4tango-doc: manpage-has-bad-whatis-entry usr/share/man/man3/log4tango::StringLiteralComponent.3.gz
W: liblog4tango-doc: manpage-has-bad-whatis-entry usr/share/man/man3/log4tango::StringUtil.3.gz
W: liblog4tango-doc: manpage-has-bad-whatis-entry usr/share/man/man3/log4tango::ThreadIdComponent.3.gz
W: liblog4tango-doc: manpage-has-bad-whatis-entry usr/share/man/man3/log4tango::ThreadNameComponent.3.gz
W: liblog4tango-doc: manpage-has-bad-whatis-entry usr/share/man/man3/log4tango::TimeStamp.3.gz
W: liblog4tango-doc: manpage-has-bad-whatis-entry usr/share/man/man3/log4tango::TimeStampComponent.3.gz
W: liblog4tango-doc: manpage-has-bad-whatis-entry usr/share/man/man3/log4tango::threading.3.gz
W: liblog4tango-doc: manpage-has-bad-whatis-entry usr/share/man/man3/log4tango::threading::Mutex.3.gz
W: liblog4tango-doc: manpage-has-bad-whatis-entry usr/share/man/man3/log4tango::threading::RecursiveMutex.3.gz
W: liblog4tango-doc: manpage-has-bad-whatis-entry usr/share/man/man3/log4tango::threading::ScopedLock.3.gz
I: liblog4tango-doc: possible-documentation-but-no-doc-base-registration
I: libtango-doc: font-in-non-font-package usr/share/doc/tango/html/_static/fonts/FontAwesome.otf.gz
I: libtango-doc: font-outside-font-dir usr/share/doc/tango/html/_static/fonts/FontAwesome.otf.gz
I: libtango-doc: font-in-non-font-package usr/share/doc/tango/html/_static/fonts/Inconsolata-Bold.ttf.gz
I: libtango-doc: font-outside-font-dir usr/share/doc/tango/html/_static/fonts/Inconsolata-Bold.ttf.gz
I: libtango-doc: font-in-non-font-package usr/share/doc/tango/html/_static/fonts/Inconsolata-Regular.ttf.gz
I: libtango-doc: font-outside-font-dir usr/share/doc/tango/html/_static/fonts/Inconsolata-Regular.ttf.gz
I: libtango-doc: font-in-non-font-package usr/share/doc/tango/html/_static/fonts/Lato-Bold.ttf.gz
I: libtango-doc: font-outside-font-dir usr/share/doc/tango/html/_static/fonts/Lato-Bold.ttf.gz
I: libtango-doc: font-in-non-font-package usr/share/doc/tango/html/_static/fonts/Lato-Regular.ttf.gz
I: libtango-doc: font-outside-font-dir usr/share/doc/tango/html/_static/fonts/Lato-Regular.ttf.gz
I: libtango-doc: font-in-non-font-package usr/share/doc/tango/html/_static/fonts/RobotoSlab-Bold.ttf.gz
I: libtango-doc: font-outside-font-dir usr/share/doc/tango/html/_static/fonts/RobotoSlab-Bold.ttf.gz
I: libtango-doc: font-in-non-font-package usr/share/doc/tango/html/_static/fonts/RobotoSlab-Regular.ttf.gz
I: libtango-doc: font-outside-font-dir usr/share/doc/tango/html/_static/fonts/RobotoSlab-Regular.ttf.gz
I: libtango-doc: font-in-non-font-package usr/share/doc/tango/html/_static/fonts/fontawesome-webfont.eot.gz
I: libtango-doc: font-outside-font-dir usr/share/doc/tango/html/_static/fonts/fontawesome-webfont.eot.gz
I: libtango-doc: font-in-non-font-package usr/share/doc/tango/html/_static/fonts/fontawesome-webfont.ttf.gz
I: libtango-doc: font-outside-font-dir usr/share/doc/tango/html/_static/fonts/fontawesome-webfont.ttf.gz
I: libtango-doc: font-in-non-font-package usr/share/doc/tango/html/_static/fonts/fontawesome-webfont.woff.gz
I: libtango-doc: font-outside-font-dir usr/share/doc/tango/html/_static/fonts/fontawesome-webfont.woff.gz
I: libtango-doc: font-in-non-font-package usr/share/doc/tango/html/_static/fonts/fontawesome-webfont.woff2.gz
I: libtango-doc: font-outside-font-dir usr/share/doc/tango/html/_static/fonts/fontawesome-webfont.woff2.gz
W: libtango-doc: privacy-breach-generic usr/share/doc/tango/html/getting-started/development/java/jtango-server.html [<img alt="jtango latest version" src="https://api.bintray.com/packages/tango-controls/jtango/jtango/images/download.svg" />] (https://api.bintray.com/packages/tango-controls/jtango/jtango/images/download.svg)
W: libtango-doc: privacy-breach-generic usr/share/doc/tango/html/installation/tango-on-linux.html [<iframe width="560" height="315" src="https://www.youtube.com/embed/f903eibiv6w?rel=0" frameborder="0" allowfullscreen>] (https://www.youtube.com/embed/f903eibiv6w?rel=0)
W: libtango-doc: privacy-breach-generic usr/share/doc/tango/html/installation/tango-on-windows.html [<iframe width="560" height="315" src="https://www.youtube.com/embed/ofrfrfiepqm?rel=0" frameborder="0" allowfullscreen>] (https://www.youtube.com/embed/ofrfrfiepqm?rel=0)
W: libtango-doc: privacy-breach-generic usr/share/doc/tango/html/installation/virtualmachine.html [<iframe src="https://player.vimeo.com/video/79554181" width="640" height="360" frameborder="0" webkitallowfullscreen mozallowfullscreen allowfullscreen>] (https://player.vimeo.com/video/79554181)
I: libtango-doc: possible-documentation-but-no-doc-base-registration
I: libtango9: spelling-error-in-binary usr/lib/x86_64-linux-gnu/libtango.so.8.4.3 lengH length
I: libtango9: spelling-error-in-binary usr/lib/x86_64-linux-gnu/libtango.so.8.4.3 occured occurred
I: libtango9: spelling-error-in-binary usr/lib/x86_64-linux-gnu/libtango.so.8.4.3 Endianess Endianness
I: libtango9: spelling-error-in-binary usr/lib/x86_64-linux-gnu/libtango.so.8.4.3 attibute attribute
I: libtango9: spelling-error-in-binary usr/lib/x86_64-linux-gnu/libtango.so.8.4.3 instanciate instantiate
I: libtango9: spelling-error-in-binary usr/lib/x86_64-linux-gnu/libtango.so.8.4.3 precission precision
W: libtango9: package-name-doesnt-match-sonames libtango8
I: libtango9: no-symbols-control-file usr/lib/x86_64-linux-gnu/libtango.so.8.4.3
W: tango-common: maintainer-script-should-not-use-recursive-chown-or-chmod postinst:67

I just put this here in order to have the information somewhere.

Maybe we can solve a bunch of them for the release.

[t-b]

@picca There is a lot of noise in these warnings like spelling errors etc. Please use also the SONAME fix from the referenced PR.

[picca]

Hello the easyer for me is to fetch from a tag.

what about tagging an rc2. We can use plenty of these tags :))

[mliszcz]

Hi @picca, you can ignore warnings coming from sphinx-build. This is known issue, see e.g. build logs on RTD: https://readthedocs.org/projects/tango-controls/builds/9687876/

[t-b]

@picca

I: tango source: wildcard-matches-nothing-in-dep5-copyright lib/cpp/client/zmq.hpp (paragraph at line 15)

We don't ship zmq.hpp anymore.

I: libtango-doc: font-in-non-font-package usr/share/doc/tango/html/_static/fonts/FontAwesome.otf.gz

sphinx package them by default so I think you sould add lintian overrides for them.

liblog4tango-doc:

In the future we will not ship liblog4tango as separate library anymore so I would not fix these.

W: tango source: sphinxdoc-but-no-sphinxdoc-depends P: tango source: rules-requires-root-missing

Your turf I guess?

I: tango-accesscontrol: hardening-no-fortify-functions usr/lib/tango/TangoAccessControl

Is there something I need to fix?

Spelling error fixes:

• https://github.com/tango-controls/cppTango/pull/621
• https://github.com/tango-controls/starter/pull/7
• https://github.com/tango-controls/TangoDatabase/pull/20

P: tango-db: missing-systemd-service-for-init.d-script tango-db

Is that something you can fix?

[t-b]

@picca You might want to subscribe to https://github.com/tango-controls/TangoSourceDistribution/issues/56. Against what debian are you building? Unstable? Is buster also feasible?

[picca]

I target for now experimental, in order to check that it build on all architectures. then I will upload into unstable. Then it will be possible to build an official backport if requested by peoples.

Cheers

[t-b]

@bourtemb I can't request a review for https://github.com/tango-controls/starter/pull/7. Could you have a look and merge it?

[t-b]

rc2 of the tango source distribution is out.

[t-b]

rc6 is out, TangoSourceDistribution as well.

[picca]

Uploaded into Debian experimental right now.

you can test it and gives some feedback.

thanks

[picca]

https://alioth-lists.debian.net/pipermail/debian-science-maintainers/2020-June/082674.html

[picca]

Here the build logs

https://buildd.debian.org/status/package.php?p=tango&suite=experimental

[t-b]

Final 9.3.6 TDS is done, see I've updated the release notes for the TDS, see https://github.com/tango-controls/TangoSourceDistribution/releases/tag/9.3.4.

@bourtemb Do we want to have a full cppTango changelog entry in the release page before announcing that on the mailing list and website? I'm not sure I can do that on the level you did for 9.3.3.

[bourtemb]

Final 9.3.6 TDS is done, see I've updated the release notes for the TDS, see https://github.com/tango-controls/TangoSourceDistribution/releases/tag/9.3.4.

@bourtemb Do we want to have a full cppTango changelog entry in the release page before announcing that on the mailing list and website? I'm not sure I can do that on the level you did for 9.3.3.

@t-b, I think it would be good to have TDS release notes focusing on the changes having some impact on users and to inform them on some software versions restrictions (java 8). We could add links to the different components release notes on github if people want to get more details?

For cppTango, it would be great to have nice release notes like for cpptango 9.3.3 for the official 9.3.4 version (there is a Release Notes file as well in cppTango repo that we forgot to update). There are less big changes since 9.3.3 with less impact on the users so I guess it should not be as big as the previous ones. If we can write nice release notes, that would be great but I know this can be time-consuming to write nice release notes. Some parts can be easily adapted from what I did for cpptango 9.3.3 (code comparison, feedback, changelog, acknowledgement). I took inspiration on this blog the last time I wrote the cppTango 9.3.3 release notes, especially on the slack release notes: https://www.appcues.com/blog/release-notes-examples