tango-controls / jive

Jive is a standalone JAVA application designed to browse and edit the static TANGO database. jive moved to https://gitlab.com/tango-controls/jive
10 stars 6 forks source link

"Updating properties" Frame is not closed after apply properties #47

Closed jkotan closed 7 years ago

jkotan commented 7 years ago

Hi,

We have noticed that when we modify more device properties at one time in jive "Updating properties" Frame is not closed properly. One can fix it by changing

 diff --git a/src/main/java/jive3/ProgressFrame.java b/src/main/java/jive3/ProgressFrame.java
index 1b5adb4..f227088 100644
--- a/src/main/java/jive3/ProgressFrame.java
+++ b/src/main/java/jive3/ProgressFrame.java
@@ -27,7 +27,7 @@ public class ProgressFrame extends JFrame {
   }

   static public void hideProgress() {
-    if(prgFrame!=null) prgFrame.setVisible(false);
+    if(prgFrame!=null) prgFrame.dispose();
   }

   // -------------------------------------------------------

It looks like using JFrame.dispose() is recommended (http://stackoverflow.com/questions/24472661/java-gui-using-setvisible)

At DESY we use debian jessie with gnome.

Best regards, Jan

Ingvord commented 7 years ago

Could you please create a PR?

Ingvord commented 7 years ago

Great! Thanks a lot for the PR!

Ingvord commented 7 years ago

I guess this one can be now closed. Reason: #48 has been merged