search

tango-controls / pytango

This project was moved to gitlab.com
http://pytango.rtfd.io
54 stars 44 forks source link

Fix memory leak for DevEncoded attributes #347

Closed ajoubertza closed 4 years ago

ajoubertza commented 4 years ago

The extra call to set_value is not necessary, and is resulting in a memory leak, as some data it allocates is not released. This is noticeable when pushing a high number of change events for a DevEncoded attribute.

See: https://github.com/tango-controls/TangoTickets/issues/30

guifrecuni commented 4 years ago

Thanks!

andygotz commented 4 years ago

Well done!

reszelaz commented 4 years ago

Thanks for the PR! I confirm it also fixes the mem leak that we observed in Sardana.

tiagocoutinho commented 4 years ago

Nice catch! Thanks to @ajoubertza and @bourtemb for helping fix this issue.