search

tangowithcode / tango_with_django_19

A beginners guide to web programming with Python / Django 1.9
Apache License 2.0
207 stars 188 forks source link

Seven tests from test.py referenced on page 69 of the .pdf may need correcting #50

Closed mccordgh closed 7 years ago

mccordgh commented 7 years ago

These tests should be passing at this point in the tutorial, as the content is there (except for the last mentioned).

Line 106 in test_index_contains_hello_message (rango.tests.Chapter4ViewTests) throws: TypeError: a bytes-like object is required, not 'str'

Line 111 in test_does_index_contain_img (rango.tests.Chapter4ViewTests) throws: TypeError: a bytes-like object is required, not 'str'

Line 123 in test_does_about_contain_img (rango.tests.Chapter4ViewTests) throws: TypeError: a bytes-like object is required, not 'str'

Line 128 in test_about_contains_create_message (rango.tests.Chapter4ViewTests) throws: TypeError: a bytes-like object is required, not 'str'

Line 178 in test_admin_interface_page_view (rango.tests.Chapter5ViewTests) throws: ModuleNotFoundError: No module named 'admin'

Line 171 in test_view_has_title (rango.tests.Chapter5ViewTests) throws: TypeError: a bytes-like object is required, not 'str'

Line 207 in test_does_slug_field_work (rango.tests.Chapter6ViewTests) throws: AttributeError: 'Category' object has no attribute 'slug'

It seems that slug field isn't even reference for another 4 pages after we are told to download tests.py and run it with python manange.py test rango

0mician commented 7 years ago

Hi Mat, the changes in this commit/PR should work https://github.com/leifos/tango_with_django_19/pull/51/commits/9671db4c97e56d5c56f626ada7918593f8e3a758

mccordgh commented 7 years ago

Those tests worked great on my end, thank you.

maxwelld90 commented 7 years ago

Hi @mccordgh, can I please ask what version of Python were you running when the tests failed?