search

tangowithcode / tango_with_django_2

Django 2 and Python 3: Tango With Django 2 Book Repository
Apache License 2.0
68 stars 23 forks source link

Bad name of the template #4

Closed piotrsynowiec closed 5 years ago

piotrsynowiec commented 5 years ago

In chapter Bootstrapping Rango / Quick Style Change there's line:

“Let’s apply these classes to our rango/categories.html template.”

There's no such a file, and the file path should be rango/cats as is here: https://github.com/leifos/tango_with_django_2/tree/master/code/tango_with_django_project/templates/rango

maxwelld90 commented 5 years ago

Thanks for your message!

I’m aware of this issue. Currently working through a revision of the book to address this inconsistency amongst others. The file that it is referring to is cats.html in the sample codebase.

Cheers, David

On 18 Jun 2019, at 15:30, piotrsynowiec notifications@github.com wrote:

In chapter Bootstrapping Rango / Quick Style Change there's line:

“Let’s apply these classes to our rango/categories.html template.”

There's no such a file, and the file path should be rango/category.html as is here: https://github.com/leifos/tango_with_django_2/tree/master/code/tango_with_django_project/templates/rango https://github.com/leifos/tango_with_django_2/tree/master/code/tango_with_django_project/templates/rango — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/leifos/tango_with_django_2/issues/4?email_source=notifications&email_token=ABD23HJC7HREQ4WZHAWGUWLP3DWQDA5CNFSM4HZAV7EKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G2FFDUQ, or mute the thread https://github.com/notifications/unsubscribe-auth/ABD23HMLV5LH6GD63YL72S3P3DWQDANCNFSM4HZAV7EA.

maxwelld90 commented 5 years ago

Problem fixed. Code and narrative now match up. Closing issue.