tangphi / pe

0 stars 0 forks source link

Add command on item name error not handled #5

Open tangphi opened 1 year ago

tangphi commented 1 year ago

This command input for add command follows the specification in UG but was however rejected with a non-descriptive error message. Users are unable to find out the reason behind why this entry is rejected, but I believe it should be an issue with the item_name field.

Input: Screenshot 2023-04-14 at 5.04.47 pm.png

UG simply says [item_name] field must be alphanumeric. Screenshot 2023-04-14 at 5.05.06 pm.png

nus-se-bot commented 1 year ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

Duplicate, reason explained

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Error Message not specifying error lies in 'quantity'

Add format followed as per UG instructions. UG states quantity must be non-negative numerical value, but error message is given for this input: Screenshot 2023-04-14 at 4.28.59 pm.png

Not handling the error.


[original: nus-cs2113-AY2223S2/pe-interim#1964] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Reason for NotInScope

Lack of specificity of error message. Error is handled, but the message could have been more meaningful. As a side note, we have indicated clearly in the UG as well for the input parameter requirements.

With these in mind, medium is inappropriate, VeryLow may be a better severity classification

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your reason]


## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your reason]
## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your reason]