search

tangrams / bubble-wrap

Bubble Wrap basemap style
http://tangrams.github.io/bubble-wrap/
MIT License
27 stars 21 forks source link

Need for a reverseGeocode pin drop icon? #140

Open tallytalwar opened 8 years ago

tallytalwar commented 8 years ago

Currently we are using search-active icon. Does it make sense to add another icon/modify the color of the icon for reverseGeocode pin drop?

nvkelso commented 8 years ago

The convention in other apps is to follow the "active" search result icon for this. If user testing shows a need for our app to diverge, let's reopen this issue.

nvkelso commented 8 years ago

Looking more into this... EM currently allows a revGeo UX during search result mode. So either we need to disable that, or provide a different pin for it.

strikethru (Google cancels the search mode and pulls up the revGeo, Apple doesn't allow revGeo during search result mode. Apple uses a special pin color for revGeo.)* /strikethru* See followup below.

tallytalwar commented 8 years ago

For me gmaps allow reversegeo pun with search results icons. On Jan 14, 2016 6:53 PM, "Nathaniel V. KELSO" notifications@github.com wrote:

Looking more into this... EM currently allows a revGeo UX during search result mode. So either we need to disable that, or provide a different pin for it. (Google cancels the search mode and pulls up the revGeo, Apple doesn't allow revGeo during search result mode. Apple uses a special pin color for revGeo.)

— Reply to this email directly or view it on GitHub https://github.com/tangrams/eraser-map/issues/140#issuecomment-171820709 .

nvkelso commented 8 years ago

I'm on iOS, you on Android?

tallytalwar commented 8 years ago

Yup android. On Jan 14, 2016 6:57 PM, "Nathaniel V. KELSO" notifications@github.com wrote:

I'm on iOS, you on Android?

— Reply to this email directly or view it on GitHub https://github.com/tangrams/eraser-map/issues/140#issuecomment-171821265 .

nvkelso commented 8 years ago

Verified you're repro on iOS. I had searched for city in Gmaps and it killed the single result and replaced with the new pin (in the same style). And Apple Maps does (with some finagling) allow a pin drop in search result view.

nvkelso commented 8 years ago

@tallytalwar Is the Android app side completed to allow a new reverseGeocode source? If not, can you please create issue in the other repo and link up here?

tallytalwar commented 8 years ago

Sure will do. It will be a very quick change to add a new reverseGeocode source, once one is available from the style sheet. Will create an issue on the eraser-map app repo.