tangrams / bubble-wrap

Bubble Wrap basemap style
http://tangrams.github.io/bubble-wrap/
MIT License
27 stars 21 forks source link

Use repeat_group for better label placement experience #141

Open tallytalwar opened 8 years ago

tallytalwar commented 8 years ago

Now that https://github.com/tangrams/tangram-es/pull/465 got merged in ES and equivalent was available on JS for some time now, we should have the eraser-map style sheet use this feature to get better placed labels.

cc. @nvkelso, @sensescape

nvkelso commented 8 years ago

Agree we should update style for repeat_group, exciting!

(The default repeat_distance on Tangram JS was sufficient for general purpose, assume the same will be true in Tangram ES.)

tallytalwar commented 8 years ago

Yup... we use the same 256px default. Results can be seen in the latest build of eraser-map :D.

nvkelso commented 8 years ago

Related: https://github.com/tangrams/eraser-map/issues/57

nvkelso commented 8 years ago

Wow, huge improvement! Looks like we will want to optimize for less repeat, need to balance how it looks on ES with the different text engine from JS. That work should be focused in #57, this issue on repeat_group.