search

tangrams / bubble-wrap

Bubble Wrap basemap style
http://tangrams.github.io/bubble-wrap/
MIT License
27 stars 21 forks source link

Use map background color instead of earth layer #204

Closed bcamper closed 8 years ago

bcamper commented 8 years ago

For this style (and some other house styles), we don't need to draw an earth layer at all, we can just use the map background color. This reduces a lot of pixel fill volume, which can be a bottleneck for us.

I found an improvement of up to 5fps depending on scene complexity (and this was on non-retina, we should also test displays with higher pixel volume).

Differ tests confirm there's not difference at all in rendering output: http://tangrams.github.io/differ/?1=https://tangrams.github.io/bubble-wrap/bubble-wrap.yaml&2=https://raw.githubusercontent.com/tangrams/bubble-wrap/background-color/bubble-wrap.yaml&lib1=0.10&lib2=0.10&ignore1&ignore2&go

nvkelso commented 8 years ago

This makes me a little nervous as there are sometimes islands that need to stack above water (and the whole Venice under water fiasco). I'll have a look.

bcamper commented 8 years ago

Hm, OK, we should find a way to address with island-specific rules if needed, because what we've been doing is hugely wasteful...

bcamper commented 8 years ago

FWIW I did a quick check on Venice and this view is pixel-identical... but I don't know all the nuanced places that this can crop up.

tangram-1474306092676

nvkelso commented 8 years ago

Verified we only set sort_rank on default values, or special on ridge and arete lines for labels. The filters for earth don't include anything else besides the polygons that are used to generate label placements (and then get dropped).

After the global variable change, see https://github.com/tangrams/bubble-wrap/pull/204#r79443635, we should merge this.