search

tangrams / cinnabar-style

Colorful cartography for that classic look
http://tangrams.github.io/cinnabar-style/
MIT License
10 stars 11 forks source link

broken oneway arrows #41

Closed matkoniecz closed 7 years ago

matkoniecz commented 7 years ago

I attempted to reuse code from https://github.com/tangrams/cinnabar-style/commit/26f200e6c9c7b5204fd5ca38a4380a4621c6112a to add oneway arrows and discovered that arrow sprite appears to be broken

Arrow sprite seems to be a rectangle - effect is visible in https://mapzen.com/tangram/play/?#18.50000/50.06934/19.94990

selection_003

(note small squares scattered across roads)

I tested arrow sprite definition to display at specified POI, small square also appeared there.

In addition I see no oneway sprite in https://github.com/tangrams/cinnabar-style/commit/26f200e6c9c7b5204fd5ca38a4380a4621c6112a#diff-e82ec2de2911d77ed0457513f4f705a7

matkoniecz commented 7 years ago

It may be also my mistake - how one is supposed to update graphic files in tangram play? I assumed that graphic files from tangram styles are automatically available (as I see no way to upload graphic file) but maybe I am mistaken.

nvkelso commented 7 years ago

I’ll have a look.

On Thu, Jul 20, 2017 at 4:38 AM, Mateusz Konieczny <notifications@github.com

wrote:

It may be also my mistake - how one is supposed to update graphic files in tangram play? I assumed that graphic files from tangram styles are automatically available (as I see no way to upload graphic file) but maybe I am mistaken.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/tangrams/cinnabar-style/issues/41#issuecomment-316677622, or mute the thread https://github.com/notifications/unsubscribe-auth/AA0EO4r_2xXahk8KydHVAwrgoFUn0YAeks5sPzw_gaJpZM4OdxnD .

nvkelso commented 7 years ago

Somehow the sprite sheet regressed to the older version without the white arrow – but Tangram doesn't know that in the YAML, it just looks for an XY region of a certain width and height in the image and displays that.

Cinnabar reuses the spritesheet from Refill (it doesn't have it's own customized icons). The sprite sheets are managed in Adobe Illustrator files with an export script. The repo is here: https://github.com/tangrams/icons

In any event, it's all fixed and working now :)

nvkelso commented 7 years ago
screen shot 2017-07-24 at 15 26 27
nvkelso commented 7 years ago

Closed via https://github.com/tangrams/cinnabar-style/releases/tag/v7.1.0. Will be on CDN tomorrow morning. (But the bug was never publicly released, was only on master for a time.)

nvkelso commented 7 years ago

This is now live on the CDN.