old: Texture dots - Githubissues

tangrams / refill-style

From Toner to Tangram

https://tangrams.github.io/refill-style

MIT License

35 stars 12 forks source link

old: Texture dots #33

Open patriciogonzalezvivo opened 7 years ago

patriciogonzalezvivo commented 7 years ago

Adding a sdf-shape that could be reused for other styles. How it works?

takes a SDF texture u_sdf
which can be transform into a fill or stroke shape
I replace the previous circle function with it

We now can do more complex patterns if we want : )

bcamper commented 7 years ago

Notes from discussion with @patriciogonzalezvivo:

Use a smaller dot texture, this one is quite big (78k), and I doubt the resolution is needed
Let's not include non-production files like the shader used to generate the dot. It's useful to save, but my goal is to have the bundler just be zip (e.g. not require any special bundling script that has to fetch additional files or exclude others).

matteblair commented 7 years ago

You could put the 'brick' tiling pattern into the SDF texture as well, to further simplify the shader!

patriciogonzalezvivo commented 7 years ago

Yes @blair1618 ! that's next on my TODO... I will wait for this PR to merge so I don't introduce a lot of changes at once. cc @nvkelso @bcamper @sensescape

patriciogonzalezvivo commented 7 years ago

@nvkelso @bcamper can we merge this?

nvkelso commented 7 years ago

@patriciogonzalezvivo can you help @sensescape and I debug why tiny-dots: don't show up at all? This is affecting landuse styles like cemetery and garden. We've set them to medium-dots in the meantime.

patriciogonzalezvivo commented 7 years ago

hi @nvkelso, not sure what you need. seams like an old PR that wasn't merge