search

tangrams / refill-style

From Toner to Tangram
https://tangrams.github.io/refill-style
MIT License
34 stars 12 forks source link

Default labels should enable all road labels early #40

Closed nvkelso closed 7 years ago

nvkelso commented 7 years ago

To match the JS rig, and related to https://github.com/tangrams/tangram/pull/484#issuecomment-278506017. The older logic is from Tangram era 0.7 but articulated labels changes more recently and the about to land curved labels make these labels look good earlier now.

Here's what the JS has, the YAML for the default labels scene file should mark them true (currently false).

text_visible_highway_e = _default;
text_visible_minor_road_e = _default;
text_visible_highway_e = _default;
text_visible_trunk_primary_e2 = _default;
text_visible_trunk_primary_e = _default;
text_visible_secondary_e = _default;
text_visible_tertiary_e = _default;
text_visible_minor_road_e = _default;
text_visible_exits_e = _default;
sensescape commented 7 years ago

I have removed _e when I consolidated the label layers, so road layers are all true and show early

nvkelso commented 7 years ago

Reopening as we'll need to modify the JS rig.

nvkelso commented 7 years ago

Fixed in 2057d45ecb6597276ef9a29fac03041ec21df8dc.