tangrams / refill-style

From Toner to Tangram
https://tangrams.github.io/refill-style
MIT License
34 stars 12 forks source link

Uniforms with random for shader texture #44

Closed sensescape closed 7 years ago

sensescape commented 7 years ago

@bcamper @nvkelso

I was able to color this texture, but how do I create uniforms when I use random values?

screen shot 2017-04-04 at 4 16 43 pm screen shot 2017-04-04 at 4 20 35 pm

https://github.com/tangrams/refill-style/blob/e86ad2f414fc785906387f24c86878da3084e9b2/refill-style.yaml#L1083-L1084

sensescape commented 7 years ago

this is done

adding u_tint to gray pattern

screen shot 2017-04-11 at 2 04 44 pm

https://github.com/tangrams/refill-style/commit/ea196468d750e88e94fa14d50f5bc54a0593826f

bcamper commented 7 years ago

Is it still grey in some places, or am I imagining that? (And/or maybe intended)

On Tue, Apr 11, 2017 at 2:05 PM, Geraldine Sarmiento < notifications@github.com> wrote:

this is done

adding u_tint to gray pattern

[image: screen shot 2017-04-11 at 2 04 44 pm] https://cloud.githubusercontent.com/assets/466585/24930853/dc01a858-1ebf-11e7-9299-e99ce17f7e27.png

ea19646 https://github.com/tangrams/refill-style/commit/ea196468d750e88e94fa14d50f5bc54a0593826f

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tangrams/refill-style/issues/44#issuecomment-293399612, or mute the thread https://github.com/notifications/unsubscribe-auth/AABBXY3qK4p_JN9F5YRSo8TdGoEdC0GOks5ru-sJgaJpZM4MzjeZ .

sensescape commented 7 years ago

made some tweaks, had to lighten the gray and add a darker color tint, here's the new version:

screen shot 2017-04-11 at 5 08 23 pm

a little hint of gray, but mostly working refill-pixel-tint

nvkelso commented 7 years ago

@bcamper is there a way to make the random affect the value, but not saturation or hue?

On Tue, Apr 11, 2017 at 5:12 PM, Geraldine Sarmiento < notifications@github.com> wrote:

made some tweaks, had to lighten the gray and add a darker color tint, here's the new version:

[image: screen shot 2017-04-11 at 5 08 23 pm] https://cloud.githubusercontent.com/assets/466585/24935870/9a4985e2-1ed9-11e7-8b8a-2c4b32755104.png

a little hint of gray, but mostly working [image: refill-pixel-tint] https://cloud.githubusercontent.com/assets/466585/24935912/0588a8e2-1eda-11e7-8ee4-ef92db4725f9.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tangrams/refill-style/issues/44#issuecomment-293436031, or mute the thread https://github.com/notifications/unsubscribe-auth/AA0EOz0j7lpV7FgOLfAmFPXj9ditLe0lks5rvBb-gaJpZM4MzjeZ .

bcamper commented 7 years ago

@sensescape made some additional tweaks and we think the grey is gone now