Smooth waves shader at high zooms

[sensescape]

@bcamper @patriciogonzalezvivo Why is the shader not smooth at z17?

Here's how it looks at z15

At z17 the edges look rough and uneven:

[sensescape]

[sensescape]

at z19

[bcamper]

@patriciogonzalezvivo ?

[patriciogonzalezvivo]

The problem is on this line: https://github.com/tangrams/refill-style/blob/gh-pages/refill-style.yaml#L691 commenting it will "solve" the problem... but also will hook the wave line pattern to screen coordinates. Before jumping and find a better strategy for this I have some questions:

• I saw that you have 3 different wave stripes patters waves, waves2 and stream-waves. What are the differences between them?

i think we should start working in a more modular structure for the shaders... so we can re-use the modules (https://github.com/tangrams/tangram-sandbox/tree/gh-pages/modules/space) I made and fix this kind of behavior fewer times. That will be ok?

[sensescape]

waves and waves 2 are basically the same, waves 2 is just slightly darker. I wanted to have more contrast between ground and water at higher zooms. I'm using waves up to z13, then it gets darker at z13 and up with waves2

stream-waves are used for the river lines:

Yes, modular structure sounds good! Thanks!

[bcamper]

@patriciogonzalezvivo could you help with modularization? Basically structure it so we can pull some of the reusable bits out into other files, once we have file include functionality.

[patriciogonzalezvivo]

working on it

[patriciogonzalezvivo]

I have simplify version of it here: http://tangrams.github.io/tangram-play/?scene=https://gist.githubusercontent.com/anonymous/bfcf61663b6bc183d284/raw/6a820cc0a4d84266b753a3b00f17cedcc5e7ab8b/scene.yaml

Need some fine tunning... Should I merge it @sensescape ?? or you want to do it after doing the adjustments?

[sensescape]

ok merge. Thanks @patriciogonzalezvivo !

[patriciogonzalezvivo]

Let me know if you need assistance with it : )

[patriciogonzalezvivo]

Do I merge or you?

[sensescape]

you can merge

[patriciogonzalezvivo]

Done, can you check everything looks ok?

[sensescape]

waves pattern looks great!

but the coast stripes got thicker in line width.

previous:

now:

[sensescape]

Looks like it doubled in line-width. Where do I adjust the line-width?

[patriciogonzalezvivo]

I just push a fix... Is less efficient but more flexible

[sensescape]

nice! thank you! looks amazing

[patriciogonzalezvivo]

:+1: : D :+1:

[sensescape]

this is fixed

[patriciogonzalezvivo]

yay

[sensescape]

yay!