tangrams / refill-style

From Toner to Tangram
https://tangrams.github.io/refill-style
MIT License
34 stars 12 forks source link

2 building grid shaders - new white grid shader added #55

Closed sensescape closed 7 years ago

sensescape commented 7 years ago

@bcamper @nvkelso

Hi @bcamper ! I need help with this shader. I'm adding a second building-grid shader, where the grid color is white https://github.com/tangrams/refill-style/blob/f58319b373eee93acf88571f5b4b3283162b33b1/theme/color.yaml#L312

But right now, it ignores the 2nd custom shader I created https://github.com/tangrams/refill-style/blob/f58319b373eee93acf88571f5b4b3283162b33b1/theme/color.yaml#L304-L320

Looks like this right now: tangram-19-40 71364--74 00141-20170518137

I wanted the generic buildings to have the dark grid, and all the colored buildings to have a white grid: https://github.com/tangrams/refill-style/blob/f58319b373eee93acf88571f5b4b3283162b33b1/theme/color.yaml#L81-L192

sensescape commented 7 years ago

@nvkelso @bcamper I'd like a white grid like this:

screen shot 2017-05-18 at 1 15 55 pm

Thanks!

sensescape commented 7 years ago

Also, what if I have 2 textures, one light and one bold: https://github.com/tangrams/refill-style/blob/sensescape/roads-refactor/theme/color.yaml#L355-L360

bcamper commented 7 years ago

Hey @sensescape, can you help me understand where it is failing to do what you want? In the examples above, the purple and orange buildings have the white grid, and in the first one, it seems like the other buildings have the old black grid. Where is the problem manifesting?

sensescape commented 7 years ago

@bcamper zoom-bldg

the pink building has a dark grid, i'm trying to make the grid white with this shader: https://github.com/tangrams/refill-style/blob/10da9f9c61b40da33d156bcde4bf41e934ad97bb/theme/color.yaml#L305-L321

and all the colored buildings as well, trying to make the grid white too

sensescape commented 7 years ago

@bcamper more examples from tokyo

screen shot 2017-05-18 at 2 25 54 pm

http://localhost:8000/#16/35.6863/139.7663

@bcamper the white buildings with dark gray grid is perfect, just trying to fix the colored buildings sorry not clear earlier